[ARO-5368] Try and log the VM info + console log on failure #3629
Conversation
hawkowl
added
enhancement
hawkowl
requested review from
jewzaam,
bennerv,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
tiguelu
as code owners
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
#3630 splits out the log changes |
| "github.com/Azure/ARO-RP/pkg/util/stringutils" | ||
| ) | ||
|
|
||
| func (m *manager) LogAzureInformation(ctx context.Context) (interface{}, error) { |
There was a problem hiding this comment.
I want some doc comments here about what this func does and what information it gets.
pkg/cluster/gatherlogs.go
Outdated
| {f: m.logNodes, isJSON: true}, | ||
| {f: m.logClusterOperators, isJSON: true}, | ||
| {f: m.logIngressControllers, isJSON: true}, | ||
| {f: d.LogAzureInformation, isJSON: false}, |
There was a problem hiding this comment.
How about not adding LogAzureInformation in gatherFailureLogs but adding a new method?
It would be simpler.
There was a problem hiding this comment.
This feedback doesn't make a lot of sense to me. What's the need for adding another function?
There was a problem hiding this comment.
I mean because we added d.LogAzureInformation in gatherFailureLogs, we need isJSON field and some conditional branches in here.
If we make a new method instead of gatherFailureLogs, and call d.LogAzureInformation there not in gatherFailureLogs, we can keep this method simple.
There was a problem hiding this comment.
I think that the existing process of dumping out YAML/JSON is a bit unfriendly for SREs, especially when it comes to the ClusterOperators output. I think it would be better to move some of these to more formatted output, as well as have the ability to automatically analyse the logs (e.g. the serial console logs) and output formatted results there. I'm not sure if wrapping this func in another will make it overall more simple, but I do think another pass at this whole area would be a welcome change in a separate PR.
|
Please rebase pull request. |
github-actions
bot
added
needs-rebase
hawkowl
force-pushed
the
hawkowl/e2e-failure-vm-status
branch
from
80fa07b
to
00ca0d7
Compare
hawkowl
force-pushed
the
hawkowl/e2e-failure-vm-status
branch
from
d65328a
to
c2e5526
Compare
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
hawkowl
force-pushed
the
hawkowl/e2e-failure-vm-status
branch
from
c2e5526
to
a91be7c
Compare
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Fixes: issues.redhat.com/browse/ARO-5368
Dumps the VM info + console logs on failure so that we don't need to run the Geneva Action or have the control plane still around to get it.
See #3287