Cleanup VMSS bootstrapping bash scripts #3515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…configuration into a function
…anging variables readonly
s-fairchild
added
enhancement
s-fairchild
force-pushed
the
s-fairchild/improve-bash-bootstrap
branch
from
e082074
to
91bcccd
Compare
This will make adding new packages and keys easier
…m install_pkgs array
… reuse Editing the packages and keys passed will allow for easier modification later. This also allows for function reuse.
s-fairchild
force-pushed
the
s-fairchild/improve-bash-bootstrap
branch
from
4ddffa9
to
db2b722
Compare
…ption Add starting log message for each function call rpm database corruption has been seen in testing, and Prod deployments due to concurrent rpm database operations between rpm and dnf. wait is needed due to this. remove ERR trap, we aren't attempting to trap any specific errors yet.
s-fairchild
force-pushed
the
s-fairchild/improve-bash-bootstrap
branch
from
db2b722
to
3643a06
Compare
Pass wait time as a nameref variable to allow easier modification
…ex to snake case for consistency
Make gateway log directory to be passed in to functions where it is needed, this allows the value to be set in one location. Move retry steps into a single retry function call This is to reduce code duplication Move configure_fiewall_rules file creation to use write_file Correct accept_ra_conf variable name spelling
Move docker file creation to more logical location
s-fairchild
force-pushed
the
s-fairchild/improve-bash-bootstrap
branch
from
6f444c9
to
df11d61
Compare
SudoBrendan
reviewed
Apr 17, 2024
|
|
||
| # This name is used in the case that az acr login searches for this in it's environment | ||
| local -r REGISTRY_AUTH_FILE="/root/.docker/config.json" | ||
| local -r registry_config_file="{ | ||
| "auths": { |
There was a problem hiding this comment.
missing escape characters since we are no longer EOF on this.
Need to allow addition of drop in files as well for gatewayVMSS.sh
…file writing The config file was being written twice
… PROXY_IMAGE to configure_service_proxy function
Move create_required_dirs to be the first step that runs, to ensure they exist when needed. This was mostly for the devProxyVMSS
Move dnf package and repo operations into function, move all service configuration into a function Move repository configuration higher in sequence of events, make unchanging variables readonly Add write_file function to cleanup creation of new files, appending to existing files move packages to install and rpm keys to import into arrays, this will make adding new packages and keys easier Add retry loop for rpm repo key imports, remove erroneous package from install_pkgs array Pass dnf packages and rpm keys to function calls via nameref to allow reuse, This also allows for function reuse. Add wait for all rpm related transactions to avoid rpm database corruption Add starting log message for each function call rpm database corruption has been seen in testing, and Prod deployments due to concurrent rpm database operations between rpm and dnf. wait is needed due to this. remove ERR trap, we aren't attempting to trap any specific errors yet. Increase dnf & rpm retry time to 1 minute, 5 minutes total Pass wait time as a nameref variable to allow easier modification Add parse_run_options to run individual steps for testing Add az login -i comment found in gatewayVMSS.sh, change variable syntex to snake case for consistency Port changes made in rpVMSS.sh to gatewayVMSS.sh Make gateway log directory to be passed in to functions where it is needed, this allows the value to be set in one location. Move retry steps into a single retry function call This is to reduce code duplication Move configure_fiewall_rules file creation to use write_file Correct accept_ra_conf variable name spelling Pass usage options via nameref variable that is also used by getops Move docker file creation to more logical location
s-fairchild
force-pushed
the
s-fairchild/improve-bash-bootstrap
branch
from
df11d61
to
bdf8d12
Compare
…hild/improve-bash-bootstrap Move all shared code into functions located in commonVMSS.sh to allow for reusability
|
Created a new branch when moving shared functions over to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
ARO-6773
Fixes
What this PR does / why we need it:
This is needed for a resilent to failure RP deployment.
Our current implementation has shown some faults over time with RP deployments, and need improvements in general.
Test plan for issue:
I have been testing
rpVMSS.shin an Azure VM using image RedHat:RHEL:8-lvm-gen2:latest.Mainly to catch missed syntax errors, and ensure files written are formatted as expected.
I will also need to deploy this to INT, as E2E tests do not spin up the VMSS instances, which utilize these scripts.
Example Log Output
Abort
Log
Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
Per testing mentioned in the test plan.