…configuration into a function

…anging variables readonly

…o existing files

This will make adding new packages and keys easier

…m install_pkgs array

… reuse

Editing the packages and keys passed will allow for easier modification later.
This also allows for function reuse.

…ption

Add starting log message for each function call
rpm database corruption has been seen in testing, and Prod deployments due to concurrent rpm database operations between rpm and dnf. wait is needed due to this.
remove ERR trap, we aren't attempting to trap any specific errors yet.

Pass wait time as a nameref variable to allow easier modification

…ex to snake case for consistency

Make gateway log directory to be passed in to functions where it is needed, this allows the value to be set in one location.

Move retry steps into a single retry function call

This is to reduce code duplication
Move configure_fiewall_rules file creation to use write_file
Correct accept_ra_conf variable name spelling

Move docker file creation to more logical location

Need to allow addition of drop in files as well for gatewayVMSS.sh

…file writing

The config file was being written twice

… PROXY_IMAGE to configure_service_proxy function

…configure

Move create_required_dirs to be the first step that runs, to ensure they
exist when needed. This was mostly for the devProxyVMSS

…ripts

Move dnf package and repo operations into function, move all service configuration into a function
Move repository configuration higher in sequence of events, make unchanging variables readonly
Add write_file function to cleanup creation of new files, appending to existing files
move packages to install and rpm keys to import into arrays, this will make adding new packages and keys easier
Add retry loop for rpm repo key imports, remove erroneous package from install_pkgs array
Pass dnf packages and rpm keys to function calls via nameref to allow
reuse, This also allows for function reuse.
Add wait for all rpm related transactions to avoid rpm database corruption
Add starting log message for each function call
rpm database corruption has been seen in testing, and Prod deployments due to concurrent rpm database operations between rpm and dnf. wait is needed due to this.
remove ERR trap, we aren't attempting to trap any specific errors yet.
Increase dnf & rpm retry time to 1 minute, 5 minutes total
Pass wait time as a nameref variable to allow easier modification
Add parse_run_options to run individual steps for testing
Add az login -i comment found in gatewayVMSS.sh, change variable syntex to snake case for consistency
Port changes made in rpVMSS.sh to gatewayVMSS.sh
Make gateway log directory to be passed in to functions where it is needed, this allows the value to be set in one location.
Move retry steps into a single retry function call
This is to reduce code duplication
Move configure_fiewall_rules file creation to use write_file
Correct accept_ra_conf variable name spelling
Pass usage options via nameref variable that is also used by getops
Move docker file creation to more logical location

…hild/improve-bash-bootstrap

Move all shared code into functions located in commonVMSS.sh to allow
for reusability