Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update network SDK to track2 #3594

Merged
merged 5 commits into from
Jul 11, 2024
Merged

Update network SDK to track2 #3594

merged 5 commits into from
Jul 11, 2024

Conversation

bitoku
Copy link
Collaborator

@bitoku bitoku commented May 27, 2024

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-4665

What this PR does / why we need it:

This PR introduces new track2 SDK in cluster manager.
It relates to #3568

This is blocked by #3579

Test plan for issue:

This doesn't change/add any new behaviours.
Just compile check and code review is enough.

Is there any documentation that needs to be updated for this PR?

tech debt cleanup, N/A

How do you know this will function as expected in production?

This PR itself doesn't change/add any new behaviours.

Copy link

@AldoFusterTurpin AldoFusterTurpin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even it is in Draft mode as it depends on your other PR, LGTM. Thank you for this!

pkg/util/azureclient/azuresdk/common/options.go Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jun 7, 2024

Please rebase pull request.

@github-actions github-actions bot added the needs-rebase branch needs a rebase label Jun 7, 2024
@github-actions github-actions bot removed the needs-rebase branch needs a rebase label Jun 7, 2024
@bitoku
Copy link
Collaborator Author

bitoku commented Jun 7, 2024

/azp run ci,e2e

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link

@AldoFusterTurpin AldoFusterTurpin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@bitoku bitoku added hold Hold and removed ready-for-review labels Jun 18, 2024
@bitoku bitoku marked this pull request as draft June 18, 2024 09:24
@github-actions github-actions bot added the needs-rebase branch needs a rebase label Jun 28, 2024
Copy link

Please rebase pull request.

@github-actions github-actions bot removed the needs-rebase branch needs a rebase label Jul 3, 2024
@bitoku bitoku removed the hold Hold label Jul 3, 2024
@bitoku
Copy link
Collaborator Author

bitoku commented Jul 3, 2024

/azp run ci,e2e

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@bitoku bitoku marked this pull request as ready for review July 3, 2024 15:54
Copy link
Collaborator

@mociarain mociarain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@AldoFusterTurpin AldoFusterTurpin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mociarain mociarain merged commit 6effeb1 into master Jul 11, 2024
21 checks passed
@mociarain mociarain deleted the network-track2-rest branch July 11, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants