change envvar name to skip pki unit tests #3605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitoku
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
tiguelu
as code owners
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Can you update the reference to this env var in the CI-RP Dockerfile as well? Line 56 in 6a973ea |
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
tiguelu
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes N/A
What this PR does / why we need it:
Currently to skip the pki tests, which always fail in dev env, you have to set
ARO_RUN_PKI_TESTS.Contrary to the name, if you set it, it skips the tests.
This PR changes the name to the more appropriate and understandable name, and also adds the envvar to env.example because it should be set in the dev env.
Test plan for issue:
Run
make unit-test-goin the devenv and confirm that the pki tests are skipped.Confirm that CI succeeds.
Is there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
N/A