Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce the amount of package names in the logs #3630

Merged
merged 5 commits into from
Jun 16, 2024

Conversation

hawkowl
Copy link
Collaborator

@hawkowl hawkowl commented Jun 12, 2024

ported from #3422

What this PR does / why we need it:

Reduces the number of redundant package names in the logs

Test plan for issue:

Unit tests

Is there any documentation that needs to be updated for this PR?

N/A

@hawkowl
Copy link
Collaborator Author

hawkowl commented Jun 12, 2024

/azp run ci, e2e

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

pkg/util/steps/condition_test.go Show resolved Hide resolved
pkg/util/steps/runner.go Outdated Show resolved Hide resolved
@hawkowl hawkowl force-pushed the hawkowl/cleanup-log-lines-steps branch from f4889ad to e57930c Compare June 13, 2024 04:53
@hawkowl
Copy link
Collaborator Author

hawkowl commented Jun 13, 2024

/azp run ci, e2e

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Contributor

@jaitaiwan jaitaiwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm glad these changes are being made. When I looked at this code previously I mused that it seemed unnecessarily verbose as well.

@jaitaiwan jaitaiwan merged commit e44a826 into master Jun 16, 2024
20 checks passed
@hawkowl hawkowl deleted the hawkowl/cleanup-log-lines-steps branch June 16, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready-for-review skippy pull requests raised by member of Team Skippy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants