-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce the amount of package names in the logs #3630
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkowl
added
enhancement
New feature or request
ready-for-review
skippy
pull requests raised by member of Team Skippy
labels
Jun 12, 2024
hawkowl
requested review from
jewzaam,
bennerv,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
tiguelu
as code owners
June 12, 2024 07:19
/azp run ci, e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
bitoku
reviewed
Jun 12, 2024
hawkowl
force-pushed
the
hawkowl/cleanup-log-lines-steps
branch
from
June 13, 2024 04:53
f4889ad
to
e57930c
Compare
/azp run ci, e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
jaitaiwan
approved these changes
Jun 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm glad these changes are being made. When I looked at this code previously I mused that it seemed unnecessarily verbose as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
ready-for-review
skippy
pull requests raised by member of Team Skippy
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ported from #3422
What this PR does / why we need it:
Reduces the number of redundant package names in the logs
Test plan for issue:
Unit tests
Is there any documentation that needs to be updated for this PR?
N/A