Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use track2 SDK in updateAPIIPEarly #3638

Merged
merged 2 commits into from
Jun 28, 2024
Merged

use track2 SDK in updateAPIIPEarly #3638

merged 2 commits into from
Jun 28, 2024

Conversation

bitoku
Copy link
Collaborator

@bitoku bitoku commented Jun 18, 2024

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-7316

What this PR does / why we need it:

This has the same change as #3579 , but changed tenant ID.
This will fix the failure e2e in canary.

Test plan for issue:

cluster creation in local dev.
cluster creation in canary.

Is there any documentation that needs to be updated for this PR?

N/A

How do you know this will function as expected in production?

cluster creation success

@bitoku
Copy link
Collaborator Author

bitoku commented Jun 18, 2024

/azp run ci,e2e

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@bitoku bitoku marked this pull request as ready for review June 18, 2024 14:43
@bitoku bitoku changed the title Update apiip early track2 use track2 SDK in updateAPIIPEarly Jun 18, 2024
@tiguelu tiguelu added the hold Hold label Jun 18, 2024
Copy link
Contributor

@tiguelu tiguelu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is reapplying the changes in ipaddresses files that were already reviewed in #3636, plus the bugfix for the credentials to use the cluster's tenant ID instead of the RP tenant.

@tiguelu tiguelu removed the hold Hold label Jun 28, 2024
@tiguelu tiguelu merged commit ce6152d into master Jun 28, 2024
20 checks passed
@tiguelu tiguelu deleted the updateAPIIPEarly-track2 branch June 28, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants