Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} feat: ga update for azure monitor for metrics addon (managed prometheus) #6241

Merged
merged 29 commits into from
May 10, 2023
Merged

{AKS} feat: ga update for azure monitor for metrics addon (managed prometheus) #6241

merged 29 commits into from
May 10, 2023

Conversation

bragi92
Copy link
Member

@bragi92 bragi92 commented Apr 27, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks update -n kaveeshcli22 -g kaveeshcli --enable-azuremonitormetrics --enable-windows-recording-rules

az aks create -n kaveeshcli22 -g kaveeshcli --location westeurope --enable-azuremonitormetrics --enable-windows-recording-rules --azure-monitor-workspace-resource-id "{full_id}" --grafana-resource-id "{full_id}"

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

Description

GA update for Azure Monitor Metrics. The changes for public preview where merged into the az cli extensions repo in the following PR: #5428

The GA update PR for the azure cli repo is here : Azure/azure-cli#26201

Testing Guide

az aks create and az aks update is being updated with the following parameters:

  • name: --enable-azuremonitormetrics
    type: bool
    short-summary: Enable Azure Monitor Metrics Profile
  • name: --azure-monitor-workspace-resource-id
    type: string
    short-summary: Resource ID of the Azure Monitor Workspace
  • name: --ksm-metric-labels-allow-list
    type: string
    short-summary: Comma-separated list of additional Kubernetes label keys that will be used in the resource' labels metric. By default the metric contains only name and namespace labels. To include additional labels provide a list of resource names in their plural form and Kubernetes label keys you would like to allow for them (e.g. '=namespaces=[k8s-label-1,k8s-label-n,...],pods=[app],...)'. A single '' can be provided per resource instead to allow any labels, but that has severe performance implications (e.g. '=pods=[]').
  • name: --ksm-metric-annotations-allow-list
    type: string
    short-summary: Comma-separated list of additional Kubernetes label keys that will be used in the resource' labels metric. By default the metric contains only name and namespace labels. To include additional labels provide a list of resource names in their plural form and Kubernetes label keys you would like to allow for them (e.g.'=namespaces=[k8s-label-1,k8s-label-n,...],pods=[app],...)'. A single '' can be provided per resource instead to allow any labels, but that has severe performance implications (e.g. '=pods=[]').
  • name: --grafana-resource-id
    type: string
    short-summary: Resource ID of the Azure Managed Grafana Workspace
  • name: --enable-windows-recording-rules
    type: bool
    short-summary: Enable Windows Recording Rules when enabling the Azure Monitor Metrics addon
  • name: --disable-azuremonitormetrics
    type: bool
    short-summary: Disable Azure Monitor Metrics Profile. This will delete all DCRA's associated with the cluster, any linked DCRs with the data stream = prometheus-stream and the recording rule groups created by the addon for this AKS cluster.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @bragi92,
If you want to release the new extension version.
Please write the description of changes into HISTORY.rst and update setup.py.

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 27, 2023

AKS

@ghost ghost requested a review from yanzhudd April 27, 2023 16:55
@ghost ghost assigned zhoxing-ms Apr 27, 2023
@ghost ghost added the Auto-Assign Auto assign by bot label Apr 27, 2023
@ghost ghost requested review from yonzhan and FumingZhang April 27, 2023 16:55
@ghost ghost added the AKS label Apr 27, 2023
@ghost ghost requested a review from wangzelin007 April 27, 2023 16:55
@ghost ghost assigned kairu-ms Apr 27, 2023
@ghost ghost added the extension/grafana az grafana label Apr 27, 2023
@ghost ghost requested review from kairu-ms and jsntcy April 27, 2023 16:55
@bragi92 bragi92 marked this pull request as ready for review May 3, 2023 23:22
@kairu-ms kairu-ms removed their assignment May 5, 2023
src/aks-preview/azext_aks_preview/custom.py Outdated Show resolved Hide resolved
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test pipeline to verify the change, test passed

@zhoxing-ms zhoxing-ms merged commit 73ff0f6 into Azure:main May 10, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=53825&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot extension/grafana az grafana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants