Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] add live test for upgrading a cluster to cilium #6447

Closed

Conversation

wedaly
Copy link
Member

@wedaly wedaly commented Jun 27, 2023

Add a live test for the --network-dataplane flag in the az aks update command.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks update --network-dataplane=cilium

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @wedaly,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

Hi @wedaly,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 27, 2023

AKS

@ghost ghost requested review from zhoxing-ms and yanzhudd June 27, 2023 19:15
@ghost ghost assigned zhoxing-ms Jun 27, 2023
@ghost ghost added the Auto-Assign Auto assign by bot label Jun 27, 2023
@ghost ghost requested review from yonzhan and FumingZhang June 27, 2023 19:15
@ghost ghost added the AKS label Jun 27, 2023
# update to enable cilium dataplane
update_cmd = 'aks update -g {resource_group} -n {name} --network-dataplane=cilium'

self.cmd(update_cmd, checks=[
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This currently fails with a validation error. Will update with a valid snapshot once we remove the validation blocking Cilium upgrades in AKS RP.

@wedaly wedaly closed this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants