Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Containerapp] az containerapp service: Fix deprecate version #7236

Merged
merged 3 commits into from
Feb 1, 2024
Merged

[Containerapp] az containerapp service: Fix deprecate version #7236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
855ee34
fix CI
Greedygre Feb 1, 2024
1e00efe
fix
Greedygre Feb 1, 2024
abf3d3a
dup tests
Greedygre Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/containerapp/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Release History
upcoming
++++++
* 'az containerapp add-on' : support for add-on milvus create and delete commands
* [Breaking Change] 'az containerapp service': deprecate command from Azure CLI version 2.56.1
* [Breaking Change] 'az containerapp service': deprecate command from Azure CLI version 2.59.0
Greedygre marked this conversation as resolved.
Show resolved Hide resolved
* 'az containerapp add-on' : support for add-on weaviate create and delete commands
* Upgrade api-version to 2023-11-02-preview
* 'az containerapp create/update/up': support --build-env-vars to set environment variables for build
Expand Down
12 changes: 6 additions & 6 deletions src/containerapp/azext_containerapp/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,45 +50,45 @@ def load_command_table(self, _):
with self.command_group('containerapp env dapr-component') as g:
g.custom_command('init', 'init_dapr_components', is_preview=True)

with self.command_group('containerapp service', deprecate_info=self.deprecate(redirect='containerapp add-on', expiration='2.56.1', hide=True), is_preview=True) as g:
with self.command_group('containerapp service', deprecate_info=self.deprecate(redirect='containerapp add-on', expiration='2.59.0', hide=True), is_preview=True) as g:
g.custom_command('list', 'list_all_services')

with self.command_group('containerapp add-on', is_preview=True) as g:
g.custom_command('list', 'list_all_services')

with self.command_group('containerapp service redis', deprecate_info=self.deprecate(redirect='containerapp add-on redis', expiration='2.56.1', hide=True)) as g:
with self.command_group('containerapp service redis', deprecate_info=self.deprecate(redirect='containerapp add-on redis', expiration='2.59.0', hide=True)) as g:
g.custom_command('create', 'create_redis_service', supports_no_wait=True)
g.custom_command('delete', 'delete_redis_service', confirmation=True, supports_no_wait=True)

with self.command_group('containerapp add-on redis') as g:
g.custom_command('create', 'create_redis_service', supports_no_wait=True)
g.custom_command('delete', 'delete_redis_service', confirmation=True, supports_no_wait=True)

with self.command_group('containerapp service postgres', deprecate_info=self.deprecate(redirect='containerapp add-on postgres', expiration='2.56.1', hide=True)) as g:
with self.command_group('containerapp service postgres', deprecate_info=self.deprecate(redirect='containerapp add-on postgres', expiration='2.59.0', hide=True)) as g:
g.custom_command('create', 'create_postgres_service', supports_no_wait=True)
g.custom_command('delete', 'delete_postgres_service', confirmation=True, supports_no_wait=True)

with self.command_group('containerapp add-on postgres') as g:
g.custom_command('create', 'create_postgres_service', supports_no_wait=True)
g.custom_command('delete', 'delete_postgres_service', confirmation=True, supports_no_wait=True)

with self.command_group('containerapp service kafka', deprecate_info=self.deprecate(redirect='containerapp add-on kafka', expiration='2.56.1', hide=True)) as g:
with self.command_group('containerapp service kafka', deprecate_info=self.deprecate(redirect='containerapp add-on kafka', expiration='2.59.0', hide=True)) as g:
Greedygre marked this conversation as resolved.
Show resolved Hide resolved
g.custom_command('create', 'create_kafka_service', supports_no_wait=True)
g.custom_command('delete', 'delete_kafka_service', confirmation=True, supports_no_wait=True)

with self.command_group('containerapp add-on kafka') as g:
g.custom_command('create', 'create_kafka_service', supports_no_wait=True)
g.custom_command('delete', 'delete_kafka_service', confirmation=True, supports_no_wait=True)

with self.command_group('containerapp service mariadb', deprecate_info=self.deprecate(redirect='containerapp add-on mariadb', expiration='2.56.1', hide=True)) as g:
with self.command_group('containerapp service mariadb', deprecate_info=self.deprecate(redirect='containerapp add-on mariadb', expiration='2.59.0', hide=True)) as g:
Greedygre marked this conversation as resolved.
Show resolved Hide resolved
g.custom_command('create', 'create_mariadb_service', supports_no_wait=True)
g.custom_command('delete', 'delete_mariadb_service', confirmation=True, supports_no_wait=True)

with self.command_group('containerapp add-on mariadb') as g:
g.custom_command('create', 'create_mariadb_service', supports_no_wait=True)
g.custom_command('delete', 'delete_mariadb_service', confirmation=True, supports_no_wait=True)

with self.command_group('containerapp service qdrant', deprecate_info=self.deprecate(redirect='containerapp add-on qdrant', expiration='2.56.1', hide=True)) as g:
with self.command_group('containerapp service qdrant', deprecate_info=self.deprecate(redirect='containerapp add-on qdrant', expiration='2.59.0', hide=True)) as g:
g.custom_command('create', 'create_qdrant_service', supports_no_wait=True)
g.custom_command('delete', 'delete_qdrant_service', confirmation=True, supports_no_wait=True)

Expand Down
Loading
Loading