Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Containerapp] az containerapp service: Fix deprecate version #7236

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

Greedygre
Copy link
Contributor

@Greedygre Greedygre commented Feb 1, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

The old deprecate version is too close to remove the related commands, so the CI linter failed as following, we need to set the version to a bigger one, to give the buffer time to remove the old command in the next extension version:

-  FAIL - HIGH severity: expired_command_group
    Command-Group: `containerapp service kafka` - Deprecated command group is expired and should be removed.
    Command-Group: `containerapp service mariadb` - Deprecated command group is expired and should be removed.
    Command-Group: `containerapp service postgres` - Deprecated command group is expired and should be removed.
    Command-Group: `containerapp service qdrant` - Deprecated command group is expired and should be removed.
    Command-Group: `containerapp service redis` - Deprecated command group is expired and should be removed.
    Command-Group: `containerapp service` - Deprecated command group is expired and should be removed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Feb 1, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @Greedygre,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Copy link

Hi @Greedygre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 1, 2024

Containerapp

@wangzelin007 wangzelin007 merged commit a21db49 into Azure:main Feb 1, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants