Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Add Trusted Launch Preview CLI flags #7243

Merged
merged 32 commits into from
Mar 8, 2024

Conversation

lilypan26
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

  • az aks create
  • az aks nodepool add
  • az aks nodepool update

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Feb 2, 2024

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter spot_max_price: updated property default from nan to nan please change property default from nan to nan for parameter spot_max_price of cmd aks nodepool add
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter enable_secure_boot
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter enable_vtpm
⚠️ 1006 - ParaAdd aks nodepool add cmd aks nodepool add added parameter enable_secure_boot
⚠️ 1006 - ParaAdd aks nodepool add cmd aks nodepool add added parameter enable_vtpm
⚠️ 1006 - ParaAdd aks nodepool update cmd aks nodepool update added parameter disable_secure_boot
⚠️ 1006 - ParaAdd aks nodepool update cmd aks nodepool update added parameter disable_vtpm
⚠️ 1006 - ParaAdd aks nodepool update cmd aks nodepool update added parameter enable_secure_boot
⚠️ 1006 - ParaAdd aks nodepool update cmd aks nodepool update added parameter enable_vtpm

Copy link

Hi @lilypan26,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Copy link

Hi @lilypan26,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 2, 2024

AKS

@lilypan26
Copy link
Contributor Author

generally looks good

Queued live test to validate the change.

Got a successful run here: https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=87001462&view=results

@lilypan26 lilypan26 closed this Feb 5, 2024
@lilypan26 lilypan26 reopened this Feb 5, 2024
@FumingZhang
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd
Copy link
Contributor

yanzhudd commented Feb 7, 2024

please resolve code conflicts

@FumingZhang
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

src/aks-preview/setup.py Outdated Show resolved Hide resolved
@yanzhudd yanzhudd merged commit 821f5ea into Azure:main Mar 8, 2024
14 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Mar 8, 2024

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=137841&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants