Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI wait 1.0.6 #7528

Merged
merged 24 commits into from
Jul 9, 2024
Merged

Add CLI wait 1.0.6 #7528

merged 24 commits into from
Jul 9, 2024

Conversation

qwuae1
Copy link
Contributor

@qwuae1 qwuae1 commented Apr 18, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Apr 18, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 18, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Apr 18, 2024

For more info about extension versioning, please refer to Extension version schema

@qwuae1 qwuae1 changed the title Remove verbose log 1.0.6 Add CLI wait 1.0.6 Jul 8, 2024
@qwuae1
Copy link
Contributor Author

qwuae1 commented Jul 8, 2024

@zhoxing-ms Can I get a review on this PR

@yanzhudd
Copy link
Contributor

yanzhudd commented Jul 8, 2024

please fix the linter issue of CI

Comment on lines 659 to 661
logger.info('IP address not updated yet. Waiting for a few minutes before retrying...\n')
time.sleep(300)
# Sleep for 5 minutes
Copy link
Contributor

@zhoxing-ms zhoxing-ms Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure the time.sleep(300) needs to sleep for such a long time? I'm not sure if the customer has the patience to wait for 5 minutes

Copy link
Contributor Author

@qwuae1 qwuae1 Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhoxing-ms thx, yeah 5 min will not work
pr now fully updated

the new method is the cli wait update, not 5 mins wait

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanzhudd
Copy link
Contributor

yanzhudd commented Jul 9, 2024

please add test for this change and run it in live mode to verify if the change meets your expectations.

@qwuae1
Copy link
Contributor Author

qwuae1 commented Jul 9, 2024

please add test for this change and run it in live mode to verify if the change meets your expectations.

@yanzhudd
@zhoxing-ms

yes, we already have the test for it and run
image

https://github.com/qwuae1/azure-cli-extensions/blob/6ac068937137749cac2c81bc9f905a2387e84cd9/src/vm-repair/azext_vm_repair/tests/latest/test_repair_commands.py#L702

Copy link
Contributor

@yanzhudd yanzhudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@zhoxing-ms zhoxing-ms merged commit 6a4cd12 into Azure:main Jul 9, 2024
17 of 18 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Jul 9, 2024

[Release] Update index.json for extension [ vm-repair ] : https://dev.azure.com/azclitools/release/_build/results?buildId=170777&view=results

liorstauber pushed a commit to liorstauber/azure-cli-extensions that referenced this pull request Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants