-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI wait 1.0.6 #7528
Merged
Merged
Add CLI wait 1.0.6 #7528
Changes from 18 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
4429db2
Add ASG if exist when nic is reset
WuWayland b65e72c
Revert "Add ASG if exist when nic is reset"
WuWayland 83cea66
Add back ASG if exist when nic is reset
WuWayland b1babe2
stringlize applicationSecurityGroups
WuWayland f72dcda
ASG for revert ip
WuWayland dac6103
add test case
WuWayland c09e051
Merge branch 'Azure:main' into main
qwuae1 6790a8f
1.0.6
WuWayland ad3fdda
Update custom.py
qwuae1 889f146
Merge branch 'Azure:main' into patch-2
qwuae1 3c92817
Update HISTORY.rst
qwuae1 c07d2d6
Update setup.py
qwuae1 31f2dca
Update custom.py
qwuae1 16729d7
Update custom.py
qwuae1 4f0650d
Update custom.py
qwuae1 a02b7f4
Merge branch 'Azure:main' into main
qwuae1 e035e1e
Merge branch 'main' into patch-2
qwuae1 40ca9c4
Merge pull request #1 from qwuae1/patch-2
qwuae1 784951b
Update custom.py
qwuae1 ccdcc4e
Update custom.py
qwuae1 1589b5f
Update custom.py
qwuae1 9f9ceae
Update custom.py
qwuae1 6ac0689
Update HISTORY.rst
qwuae1 123fbd1
Update test_repair_commands.py
qwuae1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure the
time.sleep(300)
needs to sleep for such a long time? I'm not sure if the customer has the patience to wait for 5 minutesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhoxing-ms thx, yeah 5 min will not work
pr now fully updated
the new method is the cli wait update, not 5 mins wait
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhoxing-ms