Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[containerapp] sessions code interpreter commands #7607

Merged
merged 48 commits into from
May 16, 2024
Merged

[containerapp] sessions code interpreter commands #7607

merged 48 commits into from
May 16, 2024

Conversation

smzeng
Copy link
Member

@smzeng smzeng commented May 13, 2024 •
edited
Loading

session code interpreter commands
This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented May 13, 2024 •
edited
Loading

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd containerapp session sub group containerapp session added

@azure-client-tools-bot-prd azure-client-tools-bot-prd
Copy link

Hi @smzeng,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented May 13, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited
Loading

⚠️ Release Suggestions

Module: containerapp

  • Update VERSION to 1.0.0b1 in src/containerapp/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@smzeng smzeng changed the title Stacy code interpreter [containerapp] code interpreter commands May 13, 2024
@smzeng smzeng changed the title [containerapp] code interpreter commands [containerapp] sessions code interpreter commands May 13, 2024
Moazzem-Hossain-pixel
Moazzem-Hossain-pixel approved these changes May 16, 2024
View reviewed changes
Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Moazzem-Hossain-pixel
Moazzem-Hossain-pixel approved these changes May 16, 2024
View reviewed changes
Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

src/containerapp/azext_containerapp/_params.py
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug fixes

@Greedygre
Copy link
Contributor

Hi @smzeng
Please modify history.rst to add the description about this fix.

@yanzhudd
Copy link
Contributor

please resolve the code conflict

@yanzhudd yanzhudd merged commit 9aef66b into Azure:main May 16, 2024
14 of 15 checks passed
Juliehzl
Juliehzl reviewed May 16, 2024
View reviewed changes
src/containerapp/azext_containerapp/_clients.py

if no_wait:
return r.json()
elif r.status_code == 201:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will your api return 201 in RP? it seems not follow arm guideline

Juliehzl
Juliehzl reviewed May 16, 2024
View reviewed changes
src/containerapp/azext_containerapp/_clients.py
return r.json()
elif r.status_code in [200, 201, 202, 204]:
logger.warning("upload success")
if r.status_code == 202:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this post operation will have 202 returned?

@smzeng smzeng mentioned this pull request Aug 7, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juliehzl Juliehzl Juliehzl left review comments

@sanchitmehta sanchitmehta sanchitmehta approved these changes

@Greedygre Greedygre Greedygre approved these changes

@yanzhudd yanzhudd yanzhudd approved these changes

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel Moazzem-Hossain-pixel approved these changes

@MoazzemHossain-bot MoazzemHossain-bot MoazzemHossain-bot approved these changes

@zhoxing-ms zhoxing-ms Awaiting requested review from zhoxing-ms

Assignees

@zhoxing-ms zhoxing-ms

Labels
None yet
Projects
None yet
Milestone
May 2024 (2024-05-21)❗ Breaking chang...
Development

Successfully merging this pull request may close these issues.