Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[db-up] Fix repeated typo in help strings #7702

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

nachoalonsoportillo
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az mysql|postgres|sql up --help

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

Hi @nachoalonsoportillo,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

azure-client-tools-bot-prd bot commented Jun 11, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 11, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Jun 11, 2024

For more info about extension versioning, please refer to Extension version schema

@nachoalonsoportillo nachoalonsoportillo changed the title Fix repeated typo in help strings [db-up] Fix repeated typo in help strings Jun 11, 2024
Copy link
Member

@calvinhzy calvinhzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the version in setup.py and history.srt to 1.0.0b1(we are following this new style of versioning) as otherwise this typo fix would not be published. Thanks.
image

@nachoalonsoportillo
Copy link
Contributor Author

Please update the version in setup.py and history.srt to 1.0.0b1(we are following this new style of versioning) as otherwise this typo fix would not be published. Thanks. image

Done in the latest commit. Thanks @calvinhzy!

@evelyn-ys
Copy link
Member

@calvinhzy Can you review this PR again?

@calvinhzy calvinhzy merged commit 3b3a2f9 into Azure:main Jun 26, 2024
15 of 16 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ db-up ] : https://dev.azure.com/azclitools/release/_build/results?buildId=167643&view=results

@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ db-up ] : https://dev.azure.com/azclitools/release/_build/results?buildId=167765&view=results

liorstauber pushed a commit to liorstauber/azure-cli-extensions that referenced this pull request Jul 14, 2024
* Fix repeated typo in help strings.

* Fix db-up version in setup.py and log update in HISTORY.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants