Communication chat test scenario remove participant - updated the error code in comment #7728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @v-vprasannak, |
️✔️Azure CLI Extensions Breaking Change Test
|
microsoft-github-policy-service
bot
added
the
customer-reported
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kairu-ms
reviewed
Jun 27, 2024
| @@ -265,7 +265,7 @@ def test_chat_remove_participants(self, communication_resource_info): | |||
| self.cmd('az communication chat participant remove --thread {thread_id} --user {user_id} --yes') | |||
|
|
|||
| # assert 'The initiator doesn\'t have the permission to perform the requested operation.' in str(raises.exception) | |||
| # For now rest endpoint returns a 500 error, so we are checking for that | |||
There was a problem hiding this comment.
It's not necessary to release a new version if only the test code changed.
There was a problem hiding this comment.
@kairu-ms, reverted the version upgrade changes
kairu-ms
approved these changes
Jul 1, 2024
liorstauber
pushed a commit
to liorstauber/azure-cli-extensions
that referenced
this pull request
Jul 14, 2024
…or code in comment (Azure#7728) * Communication chat test scenarion remove participant - updated the error code in comment * Communication - updated version and history files * Revert "Communication - updated version and history files" This reverts commit 64e4775.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Communication chat test scenario remove participant - updated the error code in comment
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.