Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Communication chat test scenario remove participant - updated the error code in comment #7728

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Communication chat test scenario remove participant - updated the error code in comment #7728

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b5a8762
Communication chat test scenarion remove participant - updated the er…
v-vprasannak Jun 19, 2024
64e4775
Communication - updated version and history files
v-vprasannak Jun 19, 2024
93c6993
Merge branch 'Azure:main' into Communication-ChatTestScenarioStatusCode
v-vprasannak Jun 27, 2024
f064b51
Revert "Communication - updated version and history files"
v-vprasannak Jun 27, 2024
82e7727
Merge branch 'Azure:main' into Communication-ChatTestScenarioStatusCode
v-vprasannak Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/communication/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

Release History
===============
1.9.4
++++++
* Update the error code in the comment - Communication chat test scenario remove participant

1.9.3
++++++
* Update Email service create - Global as the default value for Location
Expand Down
2 changes: 1 addition & 1 deletion src/communication/azext_communication/tests/latest/test_communication_chat_scenario.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ def test_chat_remove_participants(self, communication_resource_info):
self.cmd('az communication chat participant remove --thread {thread_id} --user {user_id} --yes')

# assert 'The initiator doesn\'t have the permission to perform the requested operation.' in str(raises.exception)
# For now rest endpoint returns a 500 error, so we are checking for that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not necessary to release a new version if only the test code changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kairu-ms, reverted the version upgrade changes

# For now rest endpoint returns a 403 error, so we are checking for that
assert 'Operation returned an invalid status \'Forbidden\'' in str(raises.exception)


Expand Down
2 changes: 1 addition & 1 deletion src/communication/azext_communication/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# --------------------------------------------------------------------------------------------


VERSION = '1.9.3'
VERSION = '1.9.4'


def cli_application_id():
Expand Down
Loading