Add extra unit test cases for mutable fips test #7764
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @pineapplethevoyager, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
yanzhudd,
yonzhan and
FumingZhang
|
For more info about extension versioning, please refer to Extension version schema |
| @@ -12,6 +12,10 @@ To release a new version, please select a new version number (usually plus 1 to | |||
| Pending | |||
| +++++++ | |||
|
|
|||
| 5.0.0b4 | |||
There was a problem hiding this comment.
this PR just adds more tests, maybe we don't need to bump the version @FumingZhang?
There was a problem hiding this comment.
the last draft PR had blocking warning telling me to upgrade the version but if it is better to not I can revert.
There was a problem hiding this comment.
Agree with Charlie, don't need to release a new version if you're updating tests. The warning/comment could be ignored and only required CI checks are blocking.
| @@ -9,7 +9,7 @@ | |||
|
|
|||
| from setuptools import setup, find_packages | |||
|
|
|||
| VERSION = "5.0.0b3" | |||
There was a problem hiding this comment.
this PR just adds more tests, maybe we don't need to bump the version
|
Edit: nvm rerun fixed it |
| @@ -12,6 +12,10 @@ To release a new version, please select a new version number (usually plus 1 to | |||
| Pending | |||
| +++++++ | |||
|
|
|||
| 5.0.0b4 | |||
There was a problem hiding this comment.
Agree with Charlie, don't need to release a new version if you're updating tests. The warning/comment could be ignored and only required CI checks are blocking.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks nodepool update --enable-fips-image
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.