-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra unit test cases for mutable fips test #7764
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a758ef2
mutable Fips cli flags added
pineapplethevoyager 20fcf94
Merge branch 'main' into main
pineapplethevoyager cd7a754
version bump
pineapplethevoyager fefd3b8
whitespace edits from linter
pineapplethevoyager 0eee557
remove unneeded comment
pineapplethevoyager c57ff8a
Revert test_aks_skip_gpu_driver_install.yaml
pineapplethevoyager e46aef1
added tests
pineapplethevoyager 84c07f2
Merge remote-tracking branch 'upstream/main'
pineapplethevoyager ae5e40e
add description for unit test chagnes
pineapplethevoyager d1f380d
Update version to remove merge blocker
pineapplethevoyager 0df5308
retrigger checks
pineapplethevoyager File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR just adds more tests, maybe we don't need to bump the version @FumingZhang?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the last draft PR had blocking warning telling me to upgrade the version but if it is better to not I can revert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Charlie, don't need to release a new version if you're updating tests. The warning/comment could be ignored and only required CI checks are blocking.