Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] az aks create/update: Support in place param updates for managed prom #7835

Closed
wants to merge 0 commits into from

Conversation

bragi92
Copy link
Member

@bragi92 bragi92 commented Jul 30, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks update -n kaveeshcli22 -g kaveeshcli --enable-azure-monitor-metrics --ksm-metric-labels-allow-list "namespaces=[k8s-label-1,k8s-label-n]" --ksm-metric-annotations-allow-list "pods=[k8s-annotation-1,k8s-annotation-n]"

Description
Updating the behavior of the az aks update command for managed prom to accept KSM parameter updates even when the addon is enabled on the cluster and stopping the error we throw saying that you have to disable the addon first before updating.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jul 30, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @bragi92,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @bragi92,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 30, 2024

AKS

Copy link

github-actions bot commented Jul 30, 2024

⚠️ Release Suggestions

Module: aks-preview

  • Update VERSION to 7.0.0b3 in src/aks-preview/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@FumingZhang
Copy link
Member

Please fix failed CI checks

  1. https://dev.azure.com/azclitools/public/_build/results?buildId=177174&view=logs&j=59e8686e-5e74-514d-6cad-f7d66c66b425&t=20180a09-30e4-5d69-fc0c-4652edaa2d05&l=2358
  2. https://dev.azure.com/azclitools/public/_build/results?buildId=177174&view=logs&j=506b8f13-8269-5210-246e-a3964e53141e&t=db7247cb-300d-5b59-fd6c-6258fad20b89&l=125

ERROR: ************* Module azext_aks_preview.addonconfiguration
src/aks-preview/azext_aks_preview/addonconfiguration.py:428:65: E0606: Possibly using variable 'is_service_principal' before assignment (possibly-used-before-assignment)

@bragi92
Copy link
Member Author

bragi92 commented Aug 5, 2024

@FumingZhang Sorry, while merging from main this PR got accidently closed. I have created a new one here : #7859 with fixes for the CI builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants