Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AzureBastion] Bug fixes for connect introduced in 1.20 #8020

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

aavalang
Copy link
Member

@aavalang aavalang commented Sep 24, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

aaz auto generated variable that clashed with existing variable in params causing missing argument exception. fixed by changing aaz variable name.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Sep 24, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️bastion
rule cmd_name rule_message suggest_message
⚠️ 1010 - ParaPropUpdate network bastion create cmd network bastion create update parameter bastion_host_name: updated property name from bastion_host_name to name
⚠️ 1010 - ParaPropUpdate network bastion delete cmd network bastion delete update parameter bastion_host_name: updated property name from bastion_host_name to name
⚠️ 1010 - ParaPropUpdate network bastion show cmd network bastion show update parameter bastion_host_name: updated property name from bastion_host_name to name
⚠️ 1010 - ParaPropUpdate network bastion update cmd network bastion update update parameter bastion_host_name: updated property name from bastion_host_name to name
⚠️ 1010 - ParaPropUpdate network bastion wait cmd network bastion wait update parameter bastion_host_name: updated property name from bastion_host_name to name

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 24, 2024

AzureBastion

@aavalang
Copy link
Member Author

this fixes #8003 #8004 #29943

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Sep 24, 2024

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 24, 2024
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 24, 2024
@kairu-ms kairu-ms merged commit fa2a15c into Azure:main Sep 24, 2024
20 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ bastion ] : https://dev.azure.com/azclitools/release/_build/results?buildId=192159&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants