Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AzureBastion] Bug fixes for connect introduced in 1.20 #8020

Merged
merged 3 commits into from
Sep 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/bastion/HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,19 @@

Release History
===============
1.1.1
1.3.0
++++++
* Fix for configure option, enabling it for disable gateway and ip connect scenarios.
* Bug fixes for connect rdp/ssh/tunnel.

1.2.0
++++++
* Update SDk to 2024-01-01
* Allow create bastion with zones and session recording

1.1.1
++++++
* Fix for configure option, enabling it for disable gateway and ip connect scenarios.

1.1.0
++++++
* Allow to pass `ssh_args` as positional parameter in command `az network bastion ssh`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
# define Arg Group ""

_args_schema = cls._args_schema
_args_schema.bastion_host_name = AAZStrArg(
_args_schema.name = AAZStrArg(
options=["-n", "--name"],
help="The name of the Bastion Host.",
required=True,
Expand Down Expand Up @@ -265,7 +265,7 @@ def error_format(self):
def url_parameters(self):
parameters = {
**self.serialize_url_param(
"bastionHostName", self.ctx.args.bastion_host_name,
"bastionHostName", self.ctx.args.name,
required=True,
),
**self.serialize_url_param(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
# define Arg Group ""

_args_schema = cls._args_schema
_args_schema.bastion_host_name = AAZStrArg(
_args_schema.name = AAZStrArg(
options=["-n", "--name"],
help="The name of the Bastion Host.",
required=True,
Expand Down Expand Up @@ -126,7 +126,7 @@ def error_format(self):
def url_parameters(self):
parameters = {
**self.serialize_url_param(
"bastionHostName", self.ctx.args.bastion_host_name,
"bastionHostName", self.ctx.args.name,
required=True,
),
**self.serialize_url_param(
Expand Down
4 changes: 2 additions & 2 deletions src/bastion/azext_bastion/aaz/latest/network/bastion/_show.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
# define Arg Group ""

_args_schema = cls._args_schema
_args_schema.bastion_host_name = AAZStrArg(
_args_schema.name = AAZStrArg(
options=["-n", "--name"],
help="The name of the Bastion Host.",
required=True,
Expand Down Expand Up @@ -103,7 +103,7 @@ def error_format(self):
def url_parameters(self):
parameters = {
**self.serialize_url_param(
"bastionHostName", self.ctx.args.bastion_host_name,
"bastionHostName", self.ctx.args.name,
required=True,
),
**self.serialize_url_param(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
# define Arg Group ""

_args_schema = cls._args_schema
_args_schema.bastion_host_name = AAZStrArg(
_args_schema.name = AAZStrArg(
options=["-n", "--name", "--bastion-host-name"],
help="The name of the Bastion Host.",
required=True,
Expand Down Expand Up @@ -318,7 +318,7 @@ def error_format(self):
def url_parameters(self):
parameters = {
**self.serialize_url_param(
"bastionHostName", self.ctx.args.bastion_host_name,
"bastionHostName", self.ctx.args.name,
required=True,
),
**self.serialize_url_param(
Expand Down Expand Up @@ -417,7 +417,7 @@ def error_format(self):
def url_parameters(self):
parameters = {
**self.serialize_url_param(
"bastionHostName", self.ctx.args.bastion_host_name,
"bastionHostName", self.ctx.args.name,
required=True,
),
**self.serialize_url_param(
Expand Down
4 changes: 2 additions & 2 deletions src/bastion/azext_bastion/aaz/latest/network/bastion/_wait.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
# define Arg Group ""

_args_schema = cls._args_schema
_args_schema.bastion_host_name = AAZStrArg(
_args_schema.name = AAZStrArg(
options=["-n", "--name", "--bastion-host-name"],
help="The name of the Bastion Host.",
required=True,
Expand Down Expand Up @@ -99,7 +99,7 @@ def error_format(self):
def url_parameters(self):
parameters = {
**self.serialize_url_param(
"bastionHostName", self.ctx.args.bastion_host_name,
"bastionHostName", self.ctx.args.name,
required=True,
),
**self.serialize_url_param(
Expand Down
2 changes: 1 addition & 1 deletion src/bastion/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@


# HISTORY.rst entry.
VERSION = '1.2.0'
VERSION = '1.3.0'

# The full list of classifiers is available at
# https://pypi.python.org/pypi?%3Aaction=list_classifiers
Expand Down
Loading