You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifying --enable-managed-identity and --service-principal/--client-secret at the same time will cause a MutuallyExclusiveArgumentError
Change the default value of option --enable-managed-identity from True to False
When options --service-principal and --client-secret are not specified at the same time, CLI will backfill the value of --enable-managed-identity to True to maintain the same behavior as before (that is, create an cluster with managed system assigned identity by default)
Testing Guide
History Notes
[AKS] BREAKING CHANGE: az aks create: Specifying --enable-managed-identity and --service-principal/--client-secret at the same time will cause a MutuallyExclusiveArgumentError
[AKS] BREAKING CHANGE: az aks create: Change the default value of option --enable-managed-identity from True to False
[AKS] az aks create: When options --service-principal and --client-secret are not specified at the same time, CLI will backfill the value of --enable-managed-identity to True to maintain the same behavior as before (that is, create an cluster with managed system assigned identity by default)
This checklist is used to make sure that common guidelines for a pull request are followed.
Change the default value of option --enable-managed-identity from True to False
I think it's OK that this default is true? Rest of the change seems reasonable to me though.
If the default is kept as True, I guess there is no way to distinguish whether the user has specified this option, and thus cannot raise MutuallyExclusiveArgumentError
[AKS] BREAKING CHANGE: az aks create: Specifying --enable-managed-identity and --service-principal/--client-secret at the same time will cause a MutuallyExclusiveArgumentError
[AKS] BREAKING CHANGE: az aks create: Change the default value of option --enable-managed-identity from True to False
Since this PR contains multiple breaking changes, could we release it in the next breaking change window (next Build Event sprint)?
[AKS] BREAKING CHANGE: az aks create: Specifying --enable-managed-identity and --service-principal/--client-secret at the same time will cause a MutuallyExclusiveArgumentError
[AKS] BREAKING CHANGE: az aks create: Change the default value of option --enable-managed-identity from True to False
Since this PR contains multiple breaking changes, could we release it in the next breaking change window (next Build Event sprint)?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FumingZhang
requested review from
zhoxing-ms,
andyliuliming,
jsntcy and
yanzhudd
as code owners
microsoft-github-policy-service
bot
added
Auto-Assign
zhoxing-ms
modified the milestones:
December 2023 (2024-01-09),
January 2024 (2024-02-06)
Related command
az aks createDescription
--enable-managed-identityand--service-principal/--client-secretat the same time will cause aMutuallyExclusiveArgumentError--enable-managed-identityfromTruetoFalse--service-principaland--client-secretare not specified at the same time, CLI will backfill the value of--enable-managed-identitytoTrueto maintain the same behavior as before (that is, create an cluster with managed system assigned identity by default)Testing Guide
History Notes
[AKS] BREAKING CHANGE:
az aks create: Specifying--enable-managed-identityand--service-principal/--client-secretat the same time will cause aMutuallyExclusiveArgumentError[AKS] BREAKING CHANGE:
az aks create: Change the default value of option--enable-managed-identityfromTruetoFalse[AKS]
az aks create: When options--service-principaland--client-secretare not specified at the same time, CLI will backfill the value of--enable-managed-identitytoTrueto maintain the same behavior as before (that is, create an cluster with managed system assigned identity by default)This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.