schema update #3169
Closed
schema update #3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhvb1989
requested review from
jongio,
karolz-ms,
ellismg and
wbreza
as code owners
jongio
reviewed
Jan 3, 2024
schemas/v1.0/azure.yaml.json
Outdated
| "type": "string" | ||
| } | ||
| }, | ||
| "additionalVariablesAsSecrets": { |
There was a problem hiding this comment.
This seems like overkill to me to add this feature. I also don't think the name matches the description/functionality.
The name looks like "add these" the description states "add all vars as secrets"
There was a problem hiding this comment.
name is not final. See: #3155 (comment)
jongio
reviewed
Jan 3, 2024
jongio
reviewed
Jan 3, 2024
|
moved it to: https://github.com/Azure/azure-dev/pull/3330/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
complement of: #3155
To be merged on release-day to update schema