Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema update #3169

Closed
wants to merge 4 commits into from
Closed

schema update #3169

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8496d9d
schema update
vhvb1989 Jan 3, 2024
0f1b091
remove all vars as secrets
vhvb1989 Jan 24, 2024
ede72d7
Merge branch 'main' of github.com:Azure/azure-dev into update-schema
vhvb1989 Jan 24, 2024
2a58e38
Apply suggestions from code review
vhvb1989 Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions schemas/v1.0/azure.yaml.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,28 @@
"github",
"azdo"
]
},
"variables": {
"type": "array",
"title": "Optional. List of azd environment variables to be used in the pipeline as variables.",
vhvb1989 marked this conversation as resolved.
Show resolved Hide resolved
"description": "If variable is found on azd environment, it is set as a variable for the pipeline.",
"items": {
"type": "string"
}
},
"secrets": {
"type": "array",
"title": "Optional. List of azd environment variables to be used in the pipeline as secrets.",
vhvb1989 marked this conversation as resolved.
Show resolved Hide resolved
"description": "If variable is found on azd environment, it is set as a secret for the pipeline.",
"items": {
"type": "string"
}
},
"additionalVariablesAsSecrets": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like overkill to me to add this feature. I also don't think the name matches the description/functionality.

The name looks like "add these" the description states "add all vars as secrets"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name is not final. See: #3155 (comment)

"type": "boolean",
"default": false,
"title": "Optional. Whether to add all azd environment variables as secrets to the pipeline.",
"description": "If set to true, all variables found on azd environment are set as secrets for the pipeline. (Default: false)"
}
}
},
Expand Down