Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support credential-less fileshare datastore #36392

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Support credential-less fileshare datastore #36392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cd87aa
support credential less file datastore via sdk/cli
PratibhaShrivastav18 Jul 9, 2024
cd52cbc
update changelog
PratibhaShrivastav18 Jul 9, 2024
b0809bf
update docstring
PratibhaShrivastav18 Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/ml/azure-ai-ml/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Bugs Fixed
- Workspace update no longer broken for older workspaces due to deprecated tags.
- Support credential-less fileshare datastore

## 1.18.0 (2024-07-09)

Expand Down
4 changes: 2 additions & 2 deletions sdk/ml/azure-ai-ml/azure/ai/ml/_schema/_datastore/azure_storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ class AzureFileSchema(AzureStorageSchema):
[
NestedField(AccountKeySchema),
NestedField(SasTokenSchema),
],
required=True,
NestedField(NoneCredentialsSchema),
]
)

@post_load
Expand Down
4 changes: 2 additions & 2 deletions sdk/ml/azure-ai-ml/azure/ai/ml/entities/_datastore/azure_storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class AzureFileDatastore(Datastore):
:type protocol: str
:param properties: The asset property dictionary.
:type properties: dict[str, str]
:param credentials: Credentials to use for Azure ML workspace to connect to the storage.
:param credentials: Credentials to use for Azure ML workspace to connect to the storage. Defaults to None.
:type credentials: Union[~azure.ai.ml.entities.AccountKeyConfiguration,
~azure.ai.ml.entities.SasTokenConfiguration]
:param kwargs: A dictionary of additional configuration parameters.
Expand All @@ -67,7 +67,7 @@ def __init__(
endpoint: str = _get_storage_endpoint_from_metadata(),
protocol: str = HTTPS,
properties: Optional[Dict] = None,
credentials: Union[AccountKeyConfiguration, SasTokenConfiguration],
credentials: Optional[Union[AccountKeyConfiguration, SasTokenConfiguration]] = None,
PratibhaShrivastav18 marked this conversation as resolved.
Show resolved Hide resolved
PratibhaShrivastav18 marked this conversation as resolved.
Show resolved Hide resolved
PratibhaShrivastav18 marked this conversation as resolved.
Show resolved Hide resolved
**kwargs: Any
):
kwargs[TYPE] = DatastoreType.AZURE_FILE
Expand Down