Support credential-less fileshare datastore #36392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PratibhaShrivastav18
requested review from
sogansky,
code-vicar,
pritamDas9191,
paulshealy1,
singankit,
diondrapeck,
luigiw,
kdestin,
MilesHolland,
needuv,
achauhan-scc,
kingernupur,
ninghu and
YusakuNo1
as code owners
kingernupur
reviewed
Jul 9, 2024
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
needuv
reviewed
Jul 9, 2024
needuv
approved these changes
Jul 16, 2024
diondrapeck
approved these changes
Jul 18, 2024
kingernupur
approved these changes
Jul 18, 2024
PratibhaShrivastav18
deleted the
shrivastavp/credentialless_file_datastore
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supporting credential-less fileshare datastore creation/updation, other datastores already support it. The REST interface for fileshare datastore supports it as well, modifying the schema to support from sdk side too.
All SDK Contribution checklist:
General Guidelines and Best Practices