Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] [Typing] [File Share] _models.py and aio equivalent #36393

Conversation

weirongw23-msft
Copy link
Member

:shipit:

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Jul 9, 2024
@weirongw23-msft weirongw23-msft changed the base branch from main to feature/storage-file-share-typing July 9, 2024 05:52
@vincenttran-msft
Copy link
Member

/azp run python - storage - ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@vincenttran-msft vincenttran-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly skimmed through aio but any feedback in sync applies to async-- will take a closer look at just async on the next iteration. Overall looks good! Just a couple nits

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-storage-file-share

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-storage-file-share

@weirongw23-msft weirongw23-msft merged commit 218fec2 into Azure:feature/storage-file-share-typing Aug 6, 2024
19 checks passed
@weirongw23-msft weirongw23-msft deleted the weirongw23/file-share-models branch August 6, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants