-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] [Typing] [File Share] _models.py
and aio
equivalent
#36393
[Storage] [Typing] [File Share] _models.py
and aio
equivalent
#36393
Conversation
weirongw23-msft
commented
Jul 9, 2024
/azp run python - storage - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly skimmed through aio but any feedback in sync applies to async-- will take a closer look at just async on the next iteration. Overall looks good! Just a couple nits
sdk/storage/azure-storage-file-share/azure/storage/fileshare/_file_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-share/azure/storage/fileshare/_models.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-share/azure/storage/fileshare/_models.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-share/azure/storage/fileshare/_models.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-share/azure/storage/fileshare/_models.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-share/azure/storage/fileshare/_models.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-share/azure/storage/fileshare/_models.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-share/azure/storage/fileshare/_models.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-share/azure/storage/fileshare/_models.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-share/azure/storage/fileshare/_models.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-share/azure/storage/fileshare/_models.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-share/azure/storage/fileshare/_models.py
Outdated
Show resolved
Hide resolved
API change check APIView has identified API level changes in this PR and created following API reviews. |
API change check APIView has identified API level changes in this PR and created following API reviews. |
218fec2
into
Azure:feature/storage-file-share-typing