Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] [Typing] [File Share] _models.py and aio equivalent #36393

Merged
merged 23 commits into from
Aug 6, 2024
Merged

[Storage] [Typing] [File Share] _models.py and aio equivalent #36393

merged 23 commits into from
Aug 6, 2024

Commits on Jun 24, 2024

  1. typed models up to ShareProtocolSettings

    @weirongw23-msft
    weirongw23-msft committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    a780241 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Merge branch 'feature/storage-file-share-typing' into weirongw23/file… 

    …-share-models
    @weirongw23-msft
    weirongw23-msft committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    bb0be2e View commit details
    Browse the repository at this point in the history

  2. work in progress

    @weirongw23-msft
    weirongw23-msft committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f68e758 View commit details
    Browse the repository at this point in the history

  3. more work in progress

    @weirongw23-msft
    weirongw23-msft committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    46d46ec View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/storage-file-share-typing' into weirongw23/file… 

    …-share-models
    @weirongw23-msft
    weirongw23-msft committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f72c8ba View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. changes to models

    @weirongw23-msft
    weirongw23-msft committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    b19d882 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. typed _models.py and added misc fixes to mypy errors

    @weirongw23-msft
    weirongw23-msft committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    6465add View commit details
    Browse the repository at this point in the history

  2. share name is technically not None since it's populated later, so its… 

    … type is str
    @weirongw23-msft
    weirongw23-msft committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    3495528 View commit details
    Browse the repository at this point in the history

  3. typed .../aio/_models.py

    @weirongw23-msft
    weirongw23-msft committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    93f2eee View commit details
    Browse the repository at this point in the history

  4. fixed typo

    @weirongw23-msft
    weirongw23-msft committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    ae6f98b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'feature/storage-file-share-typing' into weirongw23/file… 

    …-share-models
    @weirongw23-msft
    weirongw23-msft committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    da70cad View commit details
    Browse the repository at this point in the history

  6. Merge branch 'feature/storage-file-share-typing' into weirongw23/file… 

    …-share-models
    @weirongw23-msft
    weirongw23-msft committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    7442265 View commit details
    Browse the repository at this point in the history

  7. swapped order of variable datetime and destination snapshot

    @weirongw23-msft
    weirongw23-msft committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    3c5db41 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Merge branch 'feature/storage-file-share-typing' into weirongw23/file… 

    …-share-models
    @weirongw23-msft
    weirongw23-msft committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    184b79c View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. fixed copy properties' id type

    @weirongw23-msft
    weirongw23-msft committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    d286129 View commit details
    Browse the repository at this point in the history

  2. removed 'required' in keywords and params

    @weirongw23-msft
    weirongw23-msft committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    05f643b View commit details
    Browse the repository at this point in the history

  3. converted to Self in classmethod return types, modified list to List … 

    …for docs
    @weirongw23-msft
    weirongw23-msft committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    7c834d4 View commit details
    Browse the repository at this point in the history

  4. removed optional typing from keywords as they're optional by nature

    @weirongw23-msft
    weirongw23-msft committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e602fc1 View commit details
    Browse the repository at this point in the history

  5. spacing and lots of optional dilemma :)

    @weirongw23-msft
    weirongw23-msft committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    fc815e9 View commit details
    Browse the repository at this point in the history

  6. fixed wrong import order

    @weirongw23-msft
    weirongw23-msft committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    aed30e8 View commit details
    Browse the repository at this point in the history

  7. create gets the same love in cvar docs

    @weirongw23-msft
    weirongw23-msft committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    96d37f3 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. merge conflicts from typing feature branch

    @weirongw23-msft
    weirongw23-msft committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    c4ae04d View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. fixed type for last_reconnect_time cvar and id typo in handle

    @weirongw23-msft
    weirongw23-msft committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    0f29f59 View commit details
    Browse the repository at this point in the history