[Storage] Modified StorageRetryPolicy to skip AzureSigningError from bad storage account key
#36431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om bad storage account key
weirongw23-msft
requested review from
annatisch,
jalauzon-msft and
vincenttran-msft
as code owners
|
API change check API changes are not detected in this pull request. |
sdk/storage/azure-storage-blob/azure/storage/blob/_shared/policies.py
Outdated
Show resolved
Hide resolved
weirongw23-msft
commented
Jul 12, 2024
jalauzon-msft
approved these changes
Jul 18, 2024
weirongw23-msft
changed the title
StorageRetryPolicy to skip AzureSigningError from bad storage account keyStorageRetryPolicy to skip AzureSigningError from bad storage account key
jalauzon-msft
approved these changes
Jul 22, 2024
jalauzon-msft
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the given storage account key credential is malformed, the existing
StorageRetryPolicyretries many times and presents a long timeout before the user is presented withAzureSigningError. The policy has been modified to skip retries and immediately fail. Attached code changes, tests, and recordings, which all pass locally:At the moment, there isn't an existing mechanism to limit the time of an API call, so using
timelibrary to time such requests is one possible way to measure the runtime of retry policy. A buggy implementation may potentially cause CI to run longer than expected, but will fail the tests here.This change is to fix this Github Issue: #36379