fix: Refactoring the download process for StaticSiteClient
#936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where
ETXTBSY
andEBUSY
errors would occur when executing processes usingspawn
after the download process ran whenStaticSiteClient
did not exist.In this PR, we simplified the close processing and error handling after downloading the file by using the Streams Promises API, and stabilized the download process.
I wrote the following workflow and checked the failure rate of the
swa deploy
command in the branches before and after the improvement.deploy-new.yml
is the workflow that uses the fixes in this PR. I can see that the deployment stability has improved significantly, as the failure rate of the workflow after the fixes is 0%, whereas the failure rate of the workflow before the fixes was over 60%.Fixes #721
Fixes #799
Fixes #916