Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactoring the download process for StaticSiteClient #936

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Refactoring the download process for StaticSiteClient #936

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21db4b9
Refactoring the download process for deploy clients using the Streams…
shibayan Mar 2, 2025
fdc0b8f
Remove PassThrough pipe
shibayan Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 23 additions & 34 deletions src/core/download-binary-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import chalk from "chalk";
import crypto from "node:crypto";
import fs from "node:fs";
import stp from "node:stream/promises";
import { fetchWithProxy as fetch } from "./utils/fetch-proxy.js";
import ora from "ora";
import path from "node:path";
import { PassThrough } from "node:stream";
import { DATA_API_BUILDER_BINARY_NAME, DATA_API_BUILDER_FOLDER, DEPLOY_BINARY_NAME, DEPLOY_FOLDER } from "./constants.js";
import { logger } from "./utils/logger.js";

Expand Down Expand Up @@ -37,48 +37,37 @@ export async function downloadAndValidateBinary(
throw new Error(`Failed to download ${binaryName} binary from url ${url}. File not found (${response.status})`);
}

const bodyStream = response?.body?.pipe(new PassThrough());

createBinaryDirectoryIfNotExists(id, outputFolder);

return await new Promise<string>((resolve, reject) => {
const isPosix = platform === "linux-x64" || platform === "osx-x64";
const outputFile = path.join(outputFolder, id, downloadFilename);

const writableStream = fs.createWriteStream(outputFile, { mode: isPosix ? 0o755 : undefined });
bodyStream?.pipe(writableStream);
const isPosix = platform === "linux-x64" || platform === "osx-x64";
const outputFile = path.join(outputFolder, id, downloadFilename);

writableStream.on("end", () => {
bodyStream?.end();
});
const writableStream = fs.createWriteStream(outputFile, { mode: isPosix ? 0o755 : undefined });

writableStream.on("finish", async () => {
const computedHash = computeChecksumfromFile(outputFile).toLowerCase();
const releaseChecksum = releaseMetadata.files[platform].sha.toLowerCase();
if (computedHash !== releaseChecksum) {
try {
// in case of a failure, we remove the file
fs.unlinkSync(outputFile);
} catch {
logger.silly(`Not able to delete ${downloadFilename}, please delete manually.`);
}
await stp.pipeline(response.body, writableStream);

spinner.fail();
reject(new Error(`Checksum mismatch for ${binaryName}! Expected ${releaseChecksum}, got ${computedHash}.`));
} else {
spinner.succeed();
const computedHash = computeChecksumfromFile(outputFile).toLowerCase();
const releaseChecksum = releaseMetadata.files[platform].sha.toLowerCase();
if (computedHash !== releaseChecksum) {
try {
// in case of a failure, we remove the file
fs.unlinkSync(outputFile);
} catch {
logger.silly(`Not able to delete ${downloadFilename}, please delete manually.`);
}

logger.silly(`Checksum match: ${computedHash}`);
logger.silly(`Saved binary to ${outputFile}`);
spinner.fail();
throw new Error(`Checksum mismatch for ${binaryName}! Expected ${releaseChecksum}, got ${computedHash}.`);
} else {
spinner.succeed();

saveMetadata(releaseMetadata, outputFile, computedHash, binaryName);
logger.silly(`Checksum match: ${computedHash}`);
logger.silly(`Saved binary to ${outputFile}`);

resolve(outputFile);
}
});
saveMetadata(releaseMetadata, outputFile, computedHash, binaryName);
}

// writableStream.close();
});
return outputFile;
}

/**
Expand Down