Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix screen orientaion portrait at base activity #63

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

yunjaena
Copy link
Contributor

버그수정

fix screen orientaion portrait at base activity
@yunjaena yunjaena added the bug Something isn't working label May 26, 2020
@yunjaena yunjaena requested a review from hyerim-p May 26, 2020 15:39
@yunjaena yunjaena linked an issue May 26, 2020 that may be closed by this pull request
try {
setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_PORTRAIT);
} catch (IllegalStateException ignore) {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아무 처리없이 단순하게 try-catch만 하고 끝인가요?

Copy link
Contributor Author

@yunjaena yunjaena May 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로그를 찍도록 하겠습니다.

@hyerim-p hyerim-p merged commit 0cde78e into develop Jul 6, 2020
@nodobi nodobi deleted the bugfix/improve_issue_#19 branch April 20, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only fullscreen opaque activities can request orientation
2 participants