Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix screen orientaion portrait at base activity #63

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Fix screen orientaion portrait at base activity #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/src/main/java/in/koreatech/koin/core/activity/ActivityBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package in.koreatech.koin.core.activity;

import android.content.Context;
import android.content.pm.ActivityInfo;
import android.os.Bundle;

import androidx.annotation.Nullable;
Expand All @@ -19,6 +20,11 @@ public class ActivityBase extends AppCompatActivity implements IProgressDialog {
protected void onCreate(@Nullable Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
context = this;
try {
setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_PORTRAIT);
} catch (IllegalStateException ignore) {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아무 처리없이 단순하게 try-catch만 하고 끝인가요?

Copy link
Contributor Author

@yunjaena yunjaena May 31, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로그를 찍도록 하겠습니다.

}
}


Expand Down
38 changes: 0 additions & 38 deletions koin/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@

<activity
android:name=".ui.splash.SplashActivity"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar">
<intent-filter>
<action android:name="android.intent.action.MAIN" />
Expand All @@ -86,186 +85,149 @@
</activity>
<activity
android:name=".ui.login.LoginActivity"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.signup.SignupActivity"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.forgotpassword.ForgotPasswordActivity"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.main.MainActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.store.StoreActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.dining.DiningActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.bus.BusActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.board.BoardActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.board.ArticleActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.board.ArticleEditActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar"
android:windowSoftInputMode="adjustResize" />
<activity
android:name=".ui.callvan.CallvanActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.callvan.CreateRoomActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.usedmarket.MarketUsedActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.usedmarket.MarketUsedSellDetailActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.usedmarket.MarketUsedBuyDetailActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.usedmarket.MarketUsedBuyEditActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.usedmarket.MarketUsedSellEditActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.usedmarket.MarketUsedBuyCreateActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.usedmarket.MarketUsedSellCreateActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.userinfo.UserInfoActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.userinfo.UserInfoEditedActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.store.StoreDetailActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.circle.CircleActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.circle.CircleDetailActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.board.ArticleCommentActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.usedmarket.MarketUsedDetailCommentActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.timetable.TimetableActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.timetable.TimetableAnonymousActivity"
android:label="@string/app_name"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.land.LandActivity"
android:label="코인 커뮤니티"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.land.LandDetailActivity"
android:label="코인 커뮤니티"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.lostfound.LostFoundMainActivity"
android:label="코인 커뮤니티"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.lostfound.LostFoundDetailActivity"
android:label="코인 커뮤니티"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.lostfound.LostFoundEditActivity"
android:label="코인 커뮤니티"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.lostfound.LostFoundCommentActivity"
android:label="코인 커뮤니티"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.store.StoreFlyerViewActivity"
android:label="코인 커뮤니티"
android:screenOrientation="portrait"
android:theme="@style/Theme.AppCompat.Translucent" />
<activity
android:name=".ui.search.SearchActivity"
android:label="코인 커뮤니티"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
<activity
android:name=".ui.error.ErrorActivity"
android:label="코인 커뮤니티"
android:screenOrientation="portrait"
android:theme="@style/KAPTheme.NoActionBar" />
</application>

Expand Down