Background material: Fix material not working with floating origin mode + fix use of the sceneCenter property #17362
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17362/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17362/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17362/merge#BCU1XR#0 |
|
Devhost visualization test reporter: |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
packages/dev/core/src/Materials/Background/backgroundMaterial.ts
Outdated
Show resolved
Hide resolved
|
i would recommend updating the title to mention the bug fix (the floatingorigin change is the less impactful one i would say :) ) |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
Popov72
changed the title
|
Devhost visualization test reporter: |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
3 participants
It also fixes a bug in the original implementation of the background material because
vBackgroundCenterwas only set whenREFLECTIONFRESNELwas defined, whereas if you look at the shader code, you will see that this uniform is only used when bothREFLECTIONFRESNELandREFLECTIONFALLOFFare defined, or whenOPACITYFRESNELis defined.