Skip to content

Background material: Fix material not working with floating origin mode + fix use of the sceneCenter property #17362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2025
Merged

Background material: Fix material not working with floating origin mode + fix use of the sceneCenter property #17362

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c6e58d
Fix material not working with floating origin mode
Popov72 Oct 29, 2025
9e84e69
Remove unused code
Popov72 Oct 29, 2025
d093058
Merge branch 'master' into fix-backgroundmat-floatingoriginmode
docEdub Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions packages/dev/core/src/Materials/Background/backgroundMaterial.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { Logger } from "../../Misc/logger";
import type { Nullable, int, float } from "../../types";
import type { Scene } from "../../scene";
import type { Matrix } from "../../Maths/math.vector";
import { Vector3, Vector4 } from "../../Maths/math.vector";
import { TmpVectors, Vector3, Vector4 } from "../../Maths/math.vector";
import { VertexBuffer } from "../../Buffers/buffer";
import type { SubMesh } from "../../Meshes/subMesh";
import type { AbstractMesh } from "../../Meshes/abstractMesh";
Expand Down Expand Up @@ -964,6 +964,21 @@ export class BackgroundMaterial extends BackgroundMaterialBase {

this._uniformBuffer.updateFloat("fFovMultiplier", this._fovMultiplier);

// Fresnel
if (defines.REFLECTIONFRESNEL) {
this._uniformBuffer.updateFloat4(
"vReflectionControl",
this._reflectionControls.x,
this._reflectionControls.y,
this._reflectionControls.z,
this._reflectionControls.w
);
}
if ((defines.REFLECTIONFRESNEL && defines.REFLECTIONFALLOFF) || defines.OPACITYFRESNEL) {
const center = TmpVectors.Vector3[0].copyFrom(this.sceneCenter).subtractInPlace(scene.floatingOriginOffset);
this._uniformBuffer.updateFloat3("vBackgroundCenter", center.x, center.y, center.z);
}

// Textures
if (scene.texturesEnabled) {
if (this._diffuseTexture && MaterialFlags.DiffuseTextureEnabled) {
Expand All @@ -972,17 +987,6 @@ export class BackgroundMaterial extends BackgroundMaterialBase {

if (reflectionTexture && MaterialFlags.ReflectionTextureEnabled) {
BindIBLSamplers(scene, defines, this._uniformBuffer, reflectionTexture);

if (defines.REFLECTIONFRESNEL) {
this._uniformBuffer.updateFloat3("vBackgroundCenter", this.sceneCenter.x, this.sceneCenter.y, this.sceneCenter.z);
this._uniformBuffer.updateFloat4(
"vReflectionControl",
this._reflectionControls.x,
this._reflectionControls.y,
this._reflectionControls.z,
this._reflectionControls.w
);
}
}

if (defines.PROJECTED_GROUND) {
Expand Down
Loading