-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrumental example notebook. #555
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! My main suggestion is to include lines for both the true ATE and the biased naive estimate in the two ATE plots and to make sure both plots have the same scale on the X axis. That way it's clearer that the mean of your estimate is much closer to the true value than the naive estimate.
Other comments:
- Consider adding plots showing posterior predictive fits, e.g.
pairplot
s comparing the true and posterior predictive marginal distributions for each observed variable (X
,Y
andZ
). - Consider adding section headers corresponding more closely to other notebooks, such as those in the mediation analysis and backdoor adjustment examples. The more structurally similar this example is to the others and to the systematic workflow in the final section of the tutorial, the easier it will be to understand for someone who's already read those.
- Make sure to build (
cd docs && make html
) and inspect (python -m http.server -d docs/build/html/ <port>
and openhttps://localhost:<port>
in a browser) the docs locally to verify that things render correctly. It looks to me like the line wrapping of equation 1 might be messed up.
Oh, and also please add this to the |
Thanks! I've followed all your suggestions, please see revised version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
The notebook probably needs a bit more polishing, but I would love comments at this stage.