Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace use of bufio.Scanner #1512

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix: replace use of bufio.Scanner #1512

merged 1 commit into from
Feb 22, 2024

Conversation

didroe
Copy link
Contributor

@didroe didroe commented Feb 22, 2024

Description

Replaces all usage of bufio.Scanner with linescanner.Scanner. The bufio scanner has a limited buffer size and shouldn't be used.

Also returns the scanner error when parsing diffs.

Related

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@didroe didroe merged commit f6c002f into main Feb 22, 2024
9 checks passed
@didroe didroe deleted the fix/diff-parsing-buffer branch February 22, 2024 11:09
@gotbadger gotbadger mentioned this pull request Feb 22, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotbadger gotbadger gotbadger approved these changes

@cfabianski cfabianski Awaiting requested review from cfabianski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bearer scan --diff fails with broken pipe when line too long
2 participants
@didroe @gotbadger