-
-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PORT] Bloodsuckers #12092
base: master
Are you sure you want to change the base?
[PORT] Bloodsuckers #12092
Conversation
fixed veil power not changing identity fixed gohome power fixed sol not putting bloodsuckers to sleep fixed some malkavian clan things fixed new coffins not opening fixed the masquerade status alert not having a background fixed runtime errors fixed lunge ability slightly adjusted the persuasion rack's bloodsucker description the persuasion rack can no longer be walked over when secured securing/unsecuring a bloodsucker building plays the ratchet sfx removed the constant moodlet for bloodsuckers bloodsuckers cant use the momento mori anymore using targeted powers changes your mouse icon lunging onto a dead person removes all their chest organs
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
fixes two balloon alerts being shown when trying to vassalize a mindless mob fixes malkavians not getting a new objective when another bloodsucker breaks the masquerade fixed phobetor tears showing up as the wrong icon non-humans can no longer be vassalized (sorry animal intelligence players) renames the finaldeath proc nosferatu clan gives badback bloodsucker teams are now actually initialized malkavians can use phobetor tears if being watched by bloodsuckers or vassals cleaned up a bit of code
please do not port the code 1:1 bloodsucker code is infamously HORRIBLE and would be much better off with extensive refactors/rewrites |
fair enough |
various code cleanup and fix prs (all of which by absolucy) i rewrote the vassal conversion code
@itsmeow how are antagonist preference icons decided? I've been trying to figure this out for a few days, but haven't been able to figure it out. The code below always has the traitor icon. /datum/role_preference/antagonist/bloodsucker
name = "Bloodsucker"
description = "..."
antag_datum = /datum/antagonist/bloodsucker
preview_outfit = /datum/outfit/bloodsucker
/datum/outfit/bloodsucker
name = "Bloodsucker outfit (Preview only)"
suit = /obj/item/clothing/suit/costume/dracula I've also tried to change other antagonist preferences' preview outfits, but I couldn't even get that to work. This led me to believe that maybe they're compiled with tgui, so re-compiled it to no avail. After that I wasted my time by going down some other rabbit holes that lead no where. |
@mrmanlikesbt |
why is it bloodsucker and not vampire anyhow. Honestly ruins the vibe a bit. |
There is a vampire race and bloodsucker antagonist, I don't want to cause confusion between the two. |
Just delete vampires and rename 'em. Our vamps were always just a Halloween gimmick anyhow |
|
About The Pull Request
Bloodsuckers are originally from fulpstation, however, this pr uses a lot of monkestation's version monkestation's version.
This pr does NOT include monster hunters. The curator replaces all monster hunter interactions, sort of giving them the same importance as a chaplain.
Why It's Good For The Game
bloodsucker.antag.mp4
Testing Photographs and Procedure
Screenshots&Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑 mrmanlikesbt, TheSwain, JohnFulpWillard, absolucy
add: new antagonist, bloodsucker
imageadd: new radial menu yes and no icons
/:cl: