Small updates #14
Merged
Small updates #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use getSharedSecret instead of multiply directly. Did some digging and getSharedSecret is using multiply under the hood, but looks like there is an outstanding todo to make it constant time, so if/when that happens we wont need to update anything here.
previously, the silent payment outputs were being added at the end of the target array, which changes the order from what the caller requested. instead, keep track of the original index while creating silent payment outputs and return the targets in the original order.
|
H/t @Overtorment for the test case (cherry-picked from #13 ) |
Overtorment
approved these changes
May 31, 2024
| @@ -84,10 +85,10 @@ export class SilentPayment { | |||
| for (const group of silentPaymentGroups) { | |||
| // Bscan * a * outpoint_hash | |||
| const ecdh_shared_secret_step1 = Buffer.from(ecc.privateMultiply(outpoint_hash, a) as Uint8Array); | |||
| const ecdh_shared_secret = ecc.pointMultiply(group.Bscan, ecdh_shared_secret_step1); | |||
| const ecdh_shared_secret = Buffer.from(ecc.getSharedSecret(ecdh_shared_secret_step1, group.Bscan) as Uint8Array); | |||
There was a problem hiding this comment.
I'm curious, how is this better?
There was a problem hiding this comment.
Currently, it doesn't change anything since getSharedSecret is calling Point.multiply under the hood (which was surprising to me). But ideally, getSharedSecret should be doing a constant time multiplication. If getSharedSecret is updated in the future to do constant time multiplication, we won't have to change anything here. I seem to remember seeing a todo in the noble crypto repos about changing this to constant time, but will need to go back and find it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getSharedSecretinstead ofPoint.multiply