Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small updates #14

Merged
merged 3 commits into from
May 31, 2024
Merged

Small updates #14

merged 3 commits into from
May 31, 2024

Commits on May 31, 2024

  1. use getSharedSecret 

    Use getSharedSecret instead of multiply directly. Did some digging and getSharedSecret
is using multiply under the hood, but looks like there is an outstanding todo to make
it constant time, so if/when that happens we wont need to update anything here.
    @josibake
    josibake committed May 31, 2024
    Configuration menu
    Copy the full SHA
    92a6737 View commit details
    Browse the repository at this point in the history

  2. keep same target ordering 

    previously, the silent payment outputs were being added at the end
of the target array, which changes the order from what the caller requested.

instead, keep track of the original index while creating silent payment
outputs and return the targets in the original order.
    @josibake
    josibake committed May 31, 2024
    Configuration menu
    Copy the full SHA
    db48d38 View commit details
    Browse the repository at this point in the history

  3. TST: targets reordering

    @Overtorment @josibake
    Overtorment authored and josibake committed May 31, 2024
    Configuration menu
    Copy the full SHA
    b402b95 View commit details
    Browse the repository at this point in the history