WIP: Adopt concolor-control for auto-detection#49
Draft
epage wants to merge 1 commit intoBurntSushi:masterfrom
Draft
WIP: Adopt concolor-control for auto-detection#49epage wants to merge 1 commit intoBurntSushi:masterfrom
epage wants to merge 1 commit intoBurntSushi:masterfrom
Conversation
This is a PoC to collect feedback on a crate meant improve interoperability across various colored output crates. I'm a little uncertain on the `Buffer` - It handles `console` differently than `WriterInner` - I used the lowest common denominator of the streams but I wonder if we should add support for completely skipping stream detection For more on the motivation, see rust-cli/team#15 (comment)
This was referenced Aug 4, 2021
Author
|
One blocker for |
Author
|
@BurntSushi any input on what concolor-color needs for being adopted into termcolor on the path to resolving rust-cli/team#15? Blockers I know of
|
pksunkara
approved these changes
Aug 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PoC to collect feedback on a crate meant improve
interoperability across various colored output crates.
I'm a little uncertain on the
Bufferconsoledifferently thanWriterInnershould add support for completely skipping stream detection
For more on the motivation, see rust-cli/team#15 (comment)