Skip to content

WIP: Adopt concolor-control for auto-detection#49

Draft
epage wants to merge 1 commit intoBurntSushi:masterfrom
epage:concolor
Draft

WIP: Adopt concolor-control for auto-detection#49
epage wants to merge 1 commit intoBurntSushi:masterfrom
epage:concolor

Conversation

@epage
Copy link

@epage epage commented Aug 4, 2021

This is a PoC to collect feedback on a crate meant improve
interoperability across various colored output crates.

I'm a little uncertain on the Buffer

  • It handles console differently than WriterInner
  • I used the lowest common denominator of the streams but I wonder if we
    should add support for completely skipping stream detection

For more on the motivation, see rust-cli/team#15 (comment)

This is a PoC to collect feedback on a crate meant improve
interoperability across various colored output crates.

I'm a little uncertain on the `Buffer`
- It handles `console` differently than `WriterInner`
- I used the lowest common denominator of the streams but I wonder if we
  should add support for completely skipping stream detection

For more on the motivation, see rust-cli/team#15 (comment)
@epage
Copy link
Author

epage commented Aug 4, 2021

One blocker for termcolor adopting this is supporting termcolors MSRV. That should be a relatively straightforward transition that I'll hold off on once we've determined this is worth pursuing.

@epage
Copy link
Author

epage commented Sep 16, 2021

@BurntSushi any input on what concolor-color needs for being adopted into termcolor on the path to resolving rust-cli/team#15?

Blockers I know of

  • A 1.0 release (blocked, waiting on any termcolor adoption input to allow for breaking changes)
  • MSRV (blocked, consolidating with other input)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants