[FIX] Fixed Unit Test Rust based on the new changes on Rust 1.86.0#1694
Merged
prateekmedia merged 1 commit intoCCExtractor:masterfrom May 18, 2025
Merged
[FIX] Fixed Unit Test Rust based on the new changes on Rust 1.86.0#1694prateekmedia merged 1 commit intoCCExtractor:masterfrom
prateekmedia merged 1 commit intoCCExtractor:masterfrom
Conversation
10 tasks
Member
|
@steel-bucket Can you rebase to current master so we can get the sample platform tests to run as well? :) |
ca93fa8 to
1c6c22e
Compare
Member
Author
|
@canihavesomecoffee I have rebased to master |
Collaborator
|
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 5b327c7...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
While working on the
sharemodule, I came across the problem that on the main branch, the Unit Test Rust(test_rust.yml) was failing. Reverting commits didn't help, later I found out that the problem was due to Rust being upgraded to 1.86.0.The New Changes to check for Null pointer De-referencing
This triggered a panic on 3 tests
test_do_cbinsrc/rust/src/lib.rstest_process_cc_datainsrc/rust/src/decoder.rstest_process_current_packetinsrc/rust/src/decoder.rsThe errors were fixed by checking for null pointers and reverting to a fallback value when true. I have used Box::leak in
decoder.rsfor now, it may be changed to a safer alternative later.How to replicate the errors for the main branch
git clone https://github.com/CCExtractor/ccextractor && cd ccextractorcd src/rustrustup updaterustup run 1.86.0 cargo test