Skip to content
Open
Show file tree
Hide file tree
Changes from 70 commits
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
f02b044
first stab at a covidCaseDatamart unit test
ericbuckley Apr 25, 2026
6873c0a
fix(rdb-modern): resolve dynamic SQL failures and data gaps in COVID …
ericbuckley Apr 25, 2026
4134b19
test(covid-case): update Public_health_case test data
ericbuckley Apr 28, 2026
83b2594
test(reporting-pipeline): add metadata columns to covid test data
ericbuckley Apr 28, 2026
08cb941
test: target rdb_modern in covidCaseDatamart query
ericbuckley Apr 28, 2026
8784b2c
test: execute sproc in covidCaseDatamart unit test
ericbuckley Apr 28, 2026
1b952f8
fixing typo
ericbuckley Apr 28, 2026
3822ace
Merge branch 'main' into eb/app-460/covid-case-datamart-fixes
ericbuckley Apr 28, 2026
c97e57d
removing semicolon
ericbuckley Apr 28, 2026
479099c
moving the sp execution to setup.sql
ericbuckley Apr 28, 2026
1bfabbb
test(reporting-pipeline-service): expand covidCaseDatamart unit test …
ericbuckley Apr 29, 2026
6db2432
more progress on constructing a good setup.sql to seed both legacy an…
ericbuckley Apr 30, 2026
88fd0e4
adding person_parent_uid to person table inserts
ericbuckley Apr 30, 2026
cc0eff1
fixing up rdb_modern setup.sql
ericbuckley Apr 30, 2026
99926b4
now using env variables in the application-test.yaml
ericbuckley Apr 30, 2026
42616c0
fixing deletes
ericbuckley Apr 30, 2026
fda05f5
fixing query and expected ordering
ericbuckley Apr 30, 2026
0b94534
adding QueryRunner debugging info for checking query result presence
ericbuckley Apr 30, 2026
f0a5bf9
more debugging
ericbuckley Apr 30, 2026
344102d
changing query to execute just 1 statement
ericbuckley Apr 30, 2026
0c4f09a
only loading rdb_modern tables in setup now
ericbuckley May 1, 2026
0a4dca7
fixing phc uid
ericbuckley May 1, 2026
39fa2cb
adding more deletes
ericbuckley May 1, 2026
1bc966c
more diagnostics for debugging
ericbuckley May 1, 2026
3ddc01a
fix debugging typo;
ericbuckley May 1, 2026
b5a6904
formatting fix
ericbuckley May 1, 2026
80f3142
more debugging
ericbuckley May 1, 2026
9f2dfa7
abort setup early if it fails
ericbuckley May 1, 2026
c950ad8
use a transaction block for running the tests
ericbuckley May 1, 2026
bcb41c3
only get errors from job_flow_log
ericbuckley May 1, 2026
6916895
formatting fix
ericbuckley May 1, 2026
8bc0429
adding delay
ericbuckley May 1, 2026
2a66904
cleaning up expected
ericbuckley May 1, 2026
edafa82
capture some sql logging when loading the setup.sql
ericbuckley May 1, 2026
3248d6b
still more debugging....
ericbuckley May 1, 2026
a2462ea
still more debugging....
ericbuckley May 1, 2026
21022b9
changing setup query to a count
ericbuckley May 1, 2026
5e5189c
now changing to a count
ericbuckley May 1, 2026
a4acdb0
run dataprocessing proc in debug mode
ericbuckley May 1, 2026
282e418
adding nrt table count debugging
ericbuckley May 1, 2026
bc947a0
more debugging counts
ericbuckley May 1, 2026
8c4da03
add missing semicolon
ericbuckley May 1, 2026
0e03c24
putting quotes around it
ericbuckley May 1, 2026
1dcc810
adding nolock
ericbuckley May 2, 2026
2060be5
more debugging
ericbuckley May 2, 2026
0643cd9
adding more debugging to job_flow_log
ericbuckley May 3, 2026
1c398a0
turn on debugging mode when running the stored proc
ericbuckley May 3, 2026
2a9f999
debugging
ericbuckley May 4, 2026
e2246fd
forcing a build of the compose services
ericbuckley May 4, 2026
f05e9b6
Merge branch 'main' into eb/app-460/covid-case-datamart-fixes
ericbuckley May 4, 2026
78907b7
fixing nrt lab test script to be able to run multiple times
ericbuckley May 5, 2026
8a7124a
removing covid case datamart debug statments
ericbuckley May 5, 2026
d017d74
reworking stored proc unit tests to not use docker
ericbuckley May 5, 2026
e83cf6f
fix nbs-mssql startup
ericbuckley May 5, 2026
ed08ddb
fixing health check
ericbuckley May 5, 2026
2f57658
fix typo
ericbuckley May 5, 2026
71345ef
revert QueryRunner debugging code
ericbuckley May 5, 2026
2134806
remove debugging code from DataDrivenUnitTests
ericbuckley May 5, 2026
7e90117
UnitTest logic cleanup
ericbuckley May 5, 2026
1f7b3af
simplify UnitTest.java
ericbuckley May 5, 2026
22b9af9
check for DB connection before running stored proc tests
ericbuckley May 5, 2026
6910527
testing using a db service in test-unit workflow
ericbuckley May 5, 2026
6cc4fba
include url in message
ericbuckley May 5, 2026
674a772
fix string variable in error message
ericbuckley May 5, 2026
cb614a9
fix host name
ericbuckley May 5, 2026
ef61c53
removing codeCaseDatamart debugging code
ericbuckley May 6, 2026
0f46e56
replacing some descriptions with code values to align with covid19etl
ericbuckley May 6, 2026
e5620d3
removing unnecessary odseSetup.sql
ericbuckley May 6, 2026
92e1207
Merge branch 'main' into eb/app-460/covid-case-datamart-fixes
ericbuckley May 6, 2026
7231bac
try disabling spring transactions on DataDrivenUnitTests
ericbuckley May 6, 2026
02a94ed
adding patient marital status cd to nrt_patient
ericbuckley May 6, 2026
7d65a25
updating PATIENT_MARITAL_STS in COVID_CASE_DATAMART to use the code v…
ericbuckley May 6, 2026
c0f2efb
fix person service unit test with new martial_status_cd transformation
ericbuckley May 6, 2026
8a8e630
bring back testcontainers for the db
ericbuckley May 6, 2026
abe3e3c
explicitly shut down the compose environment when the suite is done
ericbuckley May 6, 2026
b4ff75b
Merge branch 'main' into eb/app-460/covid-case-datamart-fixes
ericbuckley May 6, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/run-unit-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@ jobs:
permissions:
id-token: write
contents: read

services:
nbs-mssql:
image: ghcr.io/cdcgov/nedss-datareporting-mssql:6.0.18.1
ports:
- 1433:1433

steps:
- uses: actions/checkout@v6
with:
Expand All @@ -36,8 +43,11 @@ jobs:
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
restore-keys: ${{ runner.os }}-gradle

- name: Build and analyze
- name: Run stored procedure tests
working-directory: ./
env:
DB_URL_RDB: "jdbc:sqlserver://localhost:1433;databaseName=RDB_MODERN;encrypt=true;trustServerCertificate=true;loginTimeout=3;"
DB_URL_ODSE: "jdbc:sqlserver://localhost:1433;databaseName=NBS_ODSE;encrypt=true;trustServerCertificate=true;loginTimeout=3;"
run: |
./gradlew clean reporting-pipeline-service:test-unit --continue

Expand Down
2 changes: 2 additions & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ buildscript {
plugins {
id 'org.sonarqube' version '4.2.1.3168'
id 'com.diffplug.spotless' version '8.3.0'
id 'io.github.dsdolzhenko.dotenv' version '0.1.0'
}

version = '1.0.1-SNAPSHOT'
Expand All @@ -34,6 +35,7 @@ subprojects {
apply plugin: 'java'
apply plugin: 'jacoco'
apply plugin: 'com.diffplug.spotless'
apply plugin: 'io.github.dsdolzhenko.dotenv'

spotless {
// Disable incremental check if specific files are provided via CLI
Expand Down
2 changes: 1 addition & 1 deletion env.sample
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
DATABASE_PASSWORD=PizzaIsGood33!
RTR_ADMIN_NAME=rtr_admin
RTR_ADMIN_PASSWORD=rtr_admin
RTR_SERVICE_USER_NAME=rtr_server_user
RTR_SERVICE_USER_NAME=rtr_service_user
RTR_SERVICE_USER_PASSWORD=rtr_service_user
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
-- use rdb_modern;
IF EXISTS(SELECT 1 FROM NBS_ODSE.DBO.NBS_configuration WHERE config_key ='ENV' AND config_value ='UAT')
IF
EXISTS (
SELECT 1 FROM NBS_ODSE.DBO.NBS_CONFIGURATION
WHERE CONFIG_KEY = 'ENV' AND CONFIG_VALUE = 'UAT'
)
BEGIN
USE [rdb_modern];
PRINT 'Switched to database [rdb_modern]'
Expand All @@ -10,30 +14,35 @@ ELSE
PRINT 'Switched to database [rdb]';
END

IF EXISTS (SELECT 1 FROM sysobjects WHERE name = 'nrt_lab_test_result_group_key' and xtype = 'U')
AND EXISTS (SELECT 1 FROM sysobjects WHERE name = 'TEST_RESULT_GROUPING' and xtype = 'U')
IF
EXISTS (
SELECT 1 FROM SYSOBJECTS
WHERE NAME = 'nrt_lab_test_result_group_key' AND XTYPE = 'U'
)
AND EXISTS (
SELECT 1 FROM SYSOBJECTS
WHERE NAME = 'TEST_RESULT_GROUPING' AND XTYPE = 'U'
)
BEGIN

--copy already existing (TEST_RESULT_GRP_KEY, LAB_TEST_UID) from TEST_RESULT_GROUPING

SET IDENTITY_INSERT [dbo].nrt_lab_test_result_group_key ON
SET IDENTITY_INSERT [dbo].NRT_LAB_TEST_RESULT_GROUP_KEY ON

INSERT INTO [dbo].nrt_lab_test_result_group_key(
TEST_RESULT_GRP_KEY,
INSERT INTO [dbo].NRT_LAB_TEST_RESULT_GROUP_KEY (
TEST_RESULT_GRP_KEY,
LAB_TEST_UID
)
SELECT
rg.TEST_RESULT_GRP_KEY,
rg.LAB_TEST_UID
FROM [dbo].TEST_RESULT_GROUPING rg WITH(NOLOCK)
LEFT JOIN [dbo].nrt_lab_test_result_group_key k WITH(NOLOCK)
ON k.TEST_RESULT_GRP_KEY = rg.TEST_RESULT_GRP_KEY
AND k.LAB_TEST_UID= rg.LAB_TEST_UID
WHERE
k.TEST_RESULT_GRP_KEY IS NULL
AND k.LAB_TEST_UID IS NULL
ORDER BY rg.TEST_RESULT_GRP_KEY;
SELECT
RG.TEST_RESULT_GRP_KEY,
RG.LAB_TEST_UID
FROM [dbo].TEST_RESULT_GROUPING AS RG WITH (NOLOCK)
LEFT JOIN [dbo].NRT_LAB_TEST_RESULT_GROUP_KEY AS K WITH (NOLOCK)
ON RG.TEST_RESULT_GRP_KEY = K.TEST_RESULT_GRP_KEY
WHERE
K.TEST_RESULT_GRP_KEY IS NULL
ORDER BY RG.TEST_RESULT_GRP_KEY;

SET IDENTITY_INSERT [dbo].NRT_LAB_TEST_RESULT_GROUP_KEY OFF

SET IDENTITY_INSERT [dbo].nrt_lab_test_result_group_key OFF

END
END
Loading