Skip to content

[APP-427] feat: Modernize BAS_CON_LIST and BAS_CVG_LIST filters#3211

Open
emyl3 wants to merge 5 commits intomainfrom
el/app-427
Open

[APP-427] feat: Modernize BAS_CON_LIST and BAS_CVG_LIST filters#3211
emyl3 wants to merge 5 commits intomainfrom
el/app-427

Conversation

@emyl3
Copy link
Copy Markdown
Contributor

@emyl3 emyl3 commented May 6, 2026 •
edited
Loading

Description

  • Modernize the BAS_CON_LIST and BAS_CVG_LIST

BAS_CON_LIST
Screenshot 2026-05-06 at 15 04 39

BAS_CVG_LIST
Screenshot 2026-05-06 at 15 03 56
Note: Updated the DB entry for the Filter_code table so this page can use the BAS_CVG_LIST filter as shown in the screenshot above

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@emyl3 emyl3 changed the title El/app 427 [APP-427] feat: Modernize BAS_CON_LIST and BAS_CVG_LIST filters May 6, 2026
@emyl3 emyl3 marked this pull request as ready for review May 6, 2026 23:11
@emyl3 emyl3 requested a review from a team as a code owner May 6, 2026 23:11
@emyl3 emyl3 requested review from JordanGuinn and brick-green and removed request for a team May 6, 2026 23:11
mcmcgrath13
mcmcgrath13 reviewed May 7, 2026
View reviewed changes
Comment thread apps/modernization-ui/src/apps/report/run/ReportRunPage.spec.tsx
mcmcgrath13
mcmcgrath13 approved these changes May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mcmcgrath13 mcmcgrath13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcmcgrath13 mcmcgrath13 mcmcgrath13 approved these changes

@JordanGuinn JordanGuinn Awaiting requested review from JordanGuinn JordanGuinn is a code owner automatically assigned from CDCgov/nbs-phoenix

@brick-green brick-green Awaiting requested review from brick-green brick-green is a code owner automatically assigned from CDCgov/nbs-phoenix

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emyl3 @mcmcgrath13