DRAFT: run EpiAutoGP direct from juliacall#1068
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1068 +/- ##
==========================================
- Coverage 59.50% 57.06% -2.45%
==========================================
Files 32 34 +2
Lines 2109 2308 +199
==========================================
+ Hits 1255 1317 +62
- Misses 854 991 +137
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1d6453d to
f96ef26
Compare
|
Hmmmm multithreading sounds risky https://juliapy.github.io/PythonCall.jl/stable/juliacall/#py-multi-threading. I'll leave that here, but I think this approach might be nice to look at but feels too risky. AutoGP relies heavily on multi-threaded. |
| conflicts = [ | ||
| [ | ||
| {group = "dev"}, | ||
| {group = "epiautogp-julia"}, | ||
| ], | ||
| ] |
There was a problem hiding this comment.
What is the conflict? You would certainly want to be able to have all of these deps loaded for local development.
There was a problem hiding this comment.
cfa-dagster[dev] down the dep chain requires dagster-dg-core which requires tomlkit<0.13.3 whereas the juliacall in its dep chain has juliapkg>=0.1.21 which wants tomlkit>=0.13.3
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
Although I'd quite like to know more about the "bug in this version" comment!
There was a problem hiding this comment.
This is a draft/WIP PR for trying a maximalist approach to resolving #897 .
In this design, we can remove all the
.jlfiles and rely on https://github.com/JuliaPy/pyjuliapkg for julia deps and run a minimal version of model directly usingjuliacall.This means that the input/output is handled by python, and the actually forecasting code reduces the the string
JULIA_HELPER_CODE. This could be a cleaner way of interfacing toNowcastAutoGPassuming that prod bugs don't surface in implementation checks.NB: I haven't removed all the julia files in this draft yet. This is really a design example for @sbidari @dylanhmorris @damonbayer to consider.
Note that only surfaced pain point was some incompat with the
devdep group (seepyproject.toml)EDIT: there is a second surfaced pain point about config on multithread jointly with python and julia.