Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for demo #26

Closed
wants to merge 1 commit into from
Closed

fix for demo #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions terraform/implementation/ecs/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ module "ecs" {
private_subnet_ids = flatten(module.vpc.private_subnets)
vpc_id = module.vpc.vpc_id
region = var.region
alb_internal = false

owner = var.owner
project = var.project
Expand All @@ -27,5 +26,6 @@ module "ecs" {
# If intent is to pull from the phdi GHCR, set disable_ecr to true (default is false)
# disable_ecr = true
# If intent is to use the non-integrated viewer, set non_integrated_viewer to true (default is false)
# non_integrated_viewer = "true"
ecr_viewer_app_env = "test"
alb_internal = false
}
1 change: 1 addition & 0 deletions terraform/modules/ecs/_data.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ data "aws_iam_policy_document" "ecr_viewer_s3" {
"s3:PutObjectAcl",
"s3:GetObject",
"s3:GetObjectAcl",
"s3:ListBucket",
]
resources = [
aws_s3_bucket.ecr_viewer.arn,
Expand Down
1 change: 1 addition & 0 deletions terraform/modules/oidc/_data.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ data "aws_iam_policy_document" "resource_tags_update_actions" {
"iam:TagRole",
"iam:TagPolicy",
"iam:UntagPolicy",
"iam:CreatePolicyVersion",
"logs:PutRetentionPolicy",
"servicediscovery:TagResource",
]
Expand Down