feat: Optimizations for itinerary locality and SmallVec for active settings#90
Merged
RobertJacobsonCDC merged 1 commit intomainfrom May 7, 2026
Merged
Conversation
e364888 to
ba2c81d
Compare
5a01b62 to
3417511
Compare
3417511 to
7e32a23
Compare
erik-rosenstrom
approved these changes
May 5, 2026
Collaborator
erik-rosenstrom
left a comment
There was a problem hiding this comment.
Looking good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is stacked on top of #89. It introduces two optimizations:
SettingIdsandItineraryRatiosin a single property instead of in two separate properties. These are often fetched together. This improves data locality.SmallVecforget_active_settings_for_person, avoiding allocating a vector on the heap for this common operation.Local benchmark results
Keep in mind this is comparing against
RobertJacobsonCDC_setting_code_value, not the currentmainbranch. Here's a comparison to the currentmain: