Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototype: Importing JoshiaSiegel GitHub Actions #16023

Merged
merged 45 commits into from
Oct 23, 2024
Merged

Prototype: Importing JoshiaSiegel GitHub Actions #16023

merged 45 commits into from
Oct 23, 2024

Conversation

emvaldes
Copy link
Collaborator

@emvaldes emvaldes commented Sep 27, 2024 •
edited
Loading

This Pull Request (PR) is intended only as a placeholder for importing the remote GitHub Actions developed by Mr. Josiah Siegel. We will work on completing this import aiming to do not case any impact on the existing workflows.

Note: The objective is to remove any dependencies on external repositories outside the DevSecOps team.

@emvaldes emvaldes added the DevSecOps Team Aq DevSecOps work label label Sep 27, 2024
@emvaldes emvaldes added this to the in progress milestone Sep 27, 2024
@emvaldes emvaldes requested a review from devopsmatt September 27, 2024 21:45
@emvaldes emvaldes requested a review from a team as a code owner September 27, 2024 21:45
@emvaldes emvaldes requested review from devopsmatt and removed request for devopsmatt September 27, 2024 21:46
devopsmatt

This comment was marked as outdated.

Sign in to view

@devopsmatt devopsmatt marked this pull request as draft September 27, 2024 22:19
@scott-aquia
Copy link
Collaborator

Inserting a comment here to address the request from the bot

devopsmatt
devopsmatt requested changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@devopsmatt devopsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nitpicks to address.

.github/actions/deploy-backend/action.yml Outdated Show resolved Hide resolved
.github/actions/vpn-azure/action.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
.github/vpn/config.ovpn Outdated Show resolved Hide resolved
.github/workflows/alert_terraform_changes.yml Outdated Show resolved Hide resolved
.github/workflows/log_management.yml Outdated Show resolved Hide resolved
.github/workflows/prepare_deployment_branch.yaml Outdated Show resolved Hide resolved
.github/workflows/prepare_deployment_branch.yaml Outdated Show resolved Hide resolved
.github/workflows/release_to_azure.yml Outdated Show resolved Hide resolved
.github/workflows/scan_action_logs.yml Outdated Show resolved Hide resolved
emvaldes
emvaldes commented Oct 22, 2024
View reviewed changes
Copy link
Collaborator Author

@emvaldes emvaldes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressing all comments included in the PR.

.github/actions/vpn-azure/action.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
.github/workflows/alert_terraform_changes.yml Outdated Show resolved Hide resolved
.github/workflows/check_vpn.yml Outdated Show resolved Hide resolved
.github/workflows/deploy_terraform.yml Outdated Show resolved Hide resolved
.github/workflows/prepare_deployment_branch.yaml Outdated Show resolved Hide resolved
.github/workflows/prepare_deployment_branch.yaml Outdated Show resolved Hide resolved
.github/workflows/release_to_azure.yml Outdated Show resolved Hide resolved
.github/workflows/log_management.yml Outdated Show resolved Hide resolved
.github/workflows/check_vpn.yml Outdated Show resolved Hide resolved
@CDCgov CDCgov deleted a comment from github-actions bot Oct 22, 2024
@CDCgov CDCgov deleted a comment from github-actions bot Oct 22, 2024
devopsmatt
devopsmatt approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@devopsmatt devopsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CDCgov CDCgov deleted a comment from github-actions bot Oct 23, 2024
@CDCgov CDCgov deleted a comment from github-actions bot Oct 23, 2024
@emvaldes emvaldes marked this pull request as ready for review October 23, 2024 13:48
@CDCgov CDCgov deleted a comment from github-actions bot Oct 23, 2024
@CDCgov CDCgov deleted a comment from github-actions bot Oct 23, 2024
@emvaldes emvaldes merged commit d3c6ac4 into master Oct 23, 2024
19 checks passed
@emvaldes emvaldes deleted the importing-gha branch October 23, 2024 14:49
@emvaldes emvaldes changed the title Importing JoshiaSiegel GitHub Actions Prototype: Importing JoshiaSiegel GitHub Actions Dec 18, 2024
@emvaldes emvaldes added reportstream github-actions Tracking GitHub Actions items tech-debt Anything that is purely a technical issue and does not affect functionality labels Dec 18, 2024
@emvaldes emvaldes modified the milestones: in progress, done Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devopsmatt devopsmatt devopsmatt approved these changes

Assignees

@emvaldes emvaldes

@devopsmatt devopsmatt

Labels
DevSecOps Team Aq DevSecOps work label github-actions Tracking GitHub Actions items reportstream tech-debt Anything that is purely a technical issue and does not affect functionality
Projects
None yet
Milestone
done
Development

Successfully merging this pull request may close these issues.
4 participants
@emvaldes @scott-aquia @devopsmatt @devsecops-eduardovaldes